Skip to content

Commit

Permalink
Merge pull request #405 from Oksydan/accessibility-fixes
Browse files Browse the repository at this point in the history
Accessibility fixes for currency and language selector
  • Loading branch information
Oksydan authored May 7, 2024
2 parents 58e3a98 + cd253cc commit 216cf82
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 2 deletions.
4 changes: 3 additions & 1 deletion modules/ps_currencyselector/ps_currencyselector.tpl
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,9 @@
*}

<div id="_desktop_currency_selector" class="col-auto flex-grow-0 flex-shrink-0">
<select class="js-select-link form-select" aria-labelledby="currency-selector-label">
<select class="js-select-link form-select"
aria-label="{l s='Select currency' d='Shop.Falcon.Global'}"
>
{foreach from=$currencies item=currency}
<option value="{$currency.url}"{if $currency.current} selected{/if}>{$currency.iso_code}{if $currency.sign !== $currency.iso_code} {$currency.sign}{/if}</option>
{/foreach}
Expand Down
4 changes: 3 additions & 1 deletion modules/ps_languageselector/ps_languageselector.tpl
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,9 @@
* @license https://opensource.org/licenses/AFL-3.0 Academic Free License 3.0 (AFL-3.0)
*}
<div id="_desktop_language_selector" class="col-auto flex-grow-0 flex-shrink-0">
<select class="js-select-link form-select" aria-labelledby="language-selector-label">
<select class="js-select-link form-select"
aria-label="{l s='Select language' d='Shop.Falcon.Global'}"
>
{foreach from=$languages item=language}
<option value="{url entity='language' id=$language.id_lang}"{if $language.id_lang == $current_language.id_lang} selected{/if} data-iso-code="{$language.iso_code}">{$language.name_simple}</option>
{/foreach}
Expand Down

0 comments on commit 216cf82

Please sign in to comment.