This repository has been archived by the owner on Jul 22, 2024. It is now read-only.
Fix round trip issue with some time zones #239
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…at the standard period has been added to the time zone definition.
|
Note that this change conflicts with the one proposed in PR #230 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As referenced in issue #74 , some time zones are generating an XML output that fails the read procedure for the recipient. This is because of the attempt to add a transition to an open ended group when the last transition has a specified end date. This generally resulted in a transition to a period that had not been added to the TimeZoneDefinition. This change simply attempts to ensure that the period referenced by the open ended transition group exists for the TimeZoneDefinition.