found the culprit of the code size bloat

OffchainLabs · Jan 31, 2025 · 0958b2c · 0958b2c
1 parent 1e72f27
commit 0958b2c
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 5 deletions.
diff --git a/stylus-proc/src/macros/public/types.rs b/stylus-proc/src/macros/public/types.rs
@@ -64,7 +64,7 @@ impl PublicImpl {
         let fallback_deny: Option<syn::ExprIf> = match fallback_purity {
             Purity::Payable => None,
             _ => Some(parse_quote! {
-                if let Err(err) = stylus_sdk::abi::internal::deny_value("fallback") {
+                if let Err(err) = stylus_sdk::abi::internal::deny_value(storage.vm(), "fallback") {
                     return Some(Err(err));
                 }
             }),
@@ -82,7 +82,7 @@ impl PublicImpl {
         parse_quote! {
             impl<S, #generic_params> #Router<S> for #self_ty
             where
-                S: stylus_sdk::stylus_core::storage::TopLevelStorage + core::borrow::BorrowMut<Self>
+                S: stylus_sdk::stylus_core::storage::TopLevelStorage + core::borrow::BorrowMut<Self> + stylus_sdk::stylus_core::host::HostAccess,
                 #(
                     S: core::borrow::BorrowMut<#inheritance>,
                 )*
@@ -320,7 +320,7 @@ impl<E: FnExtension> PublicFn<E> {
         } else {
             let name = self.name.to_string();
             Some(parse_quote! {
-                if let Err(err) = internal::deny_value(#name) {
+                if let Err(err) = internal::deny_value(storage.vm(), #name) {
                     return Some(Err(err));
                 }
             })

diff --git a/stylus-sdk/src/abi/internal.rs b/stylus-sdk/src/abi/internal.rs
@@ -49,8 +49,8 @@ pub const fn digest_to_selector(digest: [u8; 32]) -> [u8; 4] {
 }
 
 #[allow(unused)]
-pub fn deny_value(method_name: &str) -> Result<(), Vec<u8>> {
-    if msg::value() == U256::ZERO {
+pub fn deny_value(vm: &dyn stylus_core::host::Host, method_name: &str) -> Result<(), Vec<u8>> {
+    if vm.msg_value() == U256::ZERO {
         return Ok(());
     }
     console!("method {method_name} not payable");