Flush triedb during maintenance #2892
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
diegoximenes
changed the title
diegoximenes
force-pushed
the
triedb_commit_maintenance
branch
from
5c672e1 to
8311552
Compare
diegoximenes
requested review from
magicxyyz,
ganeshvanahalli and
Tristan-Wilson
tsahee
requested changes
Jan 24, 2025
diegoximenes
force-pushed
the
triedb_commit_maintenance
branch
from
327dd54 to
e9bda8d
Compare
diegoximenes
force-pushed
the
triedb_commit_maintenance
branch
from
efa2661 to
9663e83
Compare
tsahee
requested changes
Jan 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves NIT-3047
Once in a while it takes more than 5 seconds to produce a block.
It was observed that, in several instances, "Persisted trie from memory database" which is related to HashScheme commit operation, co-occur with taking a long time to produce a block, which could indicate a causal relationship.
As an attempt to avoid that issue this PR makes Maintenance to also flush triedb to disk.
Depends on OffchainLabs/go-ethereum#398