Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: fix some problematic method name and typos in comment #2810

Merged
merged 4 commits into from
Jan 16, 2025
Merged

chore: fix some problematic method name and typos in comment #2810

merged 4 commits into from
Jan 16, 2025

Conversation

thirdkeyword
Copy link
Contributor

No description provided.

@cla-bot cla-bot
Copy link

cla-bot bot commented Nov 28, 2024

We require contributors to sign our Contributor License Agreement. In order for us to review and merge your code, please sign the linked documents below to get yourself added. https://na3.docusign.net/Member/PowerFormSigning.aspx?PowerFormId=b15c81cc-b5ea-42a6-9107-3992526f2898&env=na3&acct=6e152afc-6284-44af-a4c1-d8ef291db402&v=2

@CLAassistant
Copy link

CLAassistant commented Nov 28, 2024 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@thirdkeyword
Copy link
Contributor Author

signed

eljobe
eljobe previously approved these changes Nov 30, 2024
View reviewed changes
@eljobe eljobe requested a review from joshuacolvin0 November 30, 2024 11:32
@thirdkeyword
Copy link
Contributor Author

Thanks for the approved.

@joshuacolvin0
Copy link
Member

Please merge current master into your PR to resolve conflicts. Thanks!

@cla-bot cla-bot
Copy link

cla-bot bot commented Dec 19, 2024

We require contributors to sign our Contributor License Agreement. In order for us to review and merge your code, please sign the linked documents below to get yourself added. https://na3.docusign.net/Member/PowerFormSigning.aspx?PowerFormId=b15c81cc-b5ea-42a6-9107-3992526f2898&env=na3&acct=6e152afc-6284-44af-a4c1-d8ef291db402&v=2

1 similar comment
@cla-bot cla-bot
Copy link

cla-bot bot commented Dec 19, 2024

We require contributors to sign our Contributor License Agreement. In order for us to review and merge your code, please sign the linked documents below to get yourself added. https://na3.docusign.net/Member/PowerFormSigning.aspx?PowerFormId=b15c81cc-b5ea-42a6-9107-3992526f2898&env=na3&acct=6e152afc-6284-44af-a4c1-d8ef291db402&v=2

@cla-bot cla-bot
Copy link

cla-bot bot commented Dec 19, 2024

We require contributors to sign our Contributor License Agreement. In order for us to review and merge your code, please sign the linked documents below to get yourself added. https://na3.docusign.net/Member/PowerFormSigning.aspx?PowerFormId=b15c81cc-b5ea-42a6-9107-3992526f2898&env=na3&acct=6e152afc-6284-44af-a4c1-d8ef291db402&v=2

@cla-bot cla-bot
Copy link

cla-bot bot commented Dec 19, 2024

We require contributors to sign our Contributor License Agreement. In order for us to review and merge your code, please sign the linked documents below to get yourself added. https://na3.docusign.net/Member/PowerFormSigning.aspx?PowerFormId=b15c81cc-b5ea-42a6-9107-3992526f2898&env=na3&acct=6e152afc-6284-44af-a4c1-d8ef291db402&v=2

@thirdkeyword
Copy link
Contributor Author

Please merge current master into your PR to resolve conflicts. Thanks!

Thanks.

Please review again.

@cla-bot cla-bot
Copy link

cla-bot bot commented Jan 14, 2025

We require contributors to sign our Contributor License Agreement. In order for us to review and merge your code, please sign the linked documents below to get yourself added. https://na3.docusign.net/Member/PowerFormSigning.aspx?PowerFormId=b15c81cc-b5ea-42a6-9107-3992526f2898&env=na3&acct=6e152afc-6284-44af-a4c1-d8ef291db402&v=2

@joshuacolvin0
Copy link
Member

joshuacolvin0 commented Jan 14, 2025 •
edited
Loading

@cla-bot check

1 similar comment
@joshuacolvin0
Copy link
Member

@cla-bot check

@cla-bot cla-bot
Copy link

cla-bot bot commented Jan 14, 2025

We require contributors to sign our Contributor License Agreement. In order for us to review and merge your code, please sign the linked documents below to get yourself added. https://na3.docusign.net/Member/PowerFormSigning.aspx?PowerFormId=b15c81cc-b5ea-42a6-9107-3992526f2898&env=na3&acct=6e152afc-6284-44af-a4c1-d8ef291db402&v=2

@cla-bot cla-bot
Copy link

cla-bot bot commented Jan 14, 2025

The cla-bot has been summoned, and re-checked this pull request!

@cla-bot cla-bot
Copy link

cla-bot bot commented Jan 15, 2025

We require contributors to sign our Contributor License Agreement. In order for us to review and merge your code, please sign the linked documents below to get yourself added. https://na3.docusign.net/Member/PowerFormSigning.aspx?PowerFormId=b15c81cc-b5ea-42a6-9107-3992526f2898&env=na3&acct=6e152afc-6284-44af-a4c1-d8ef291db402&v=2

@joshuacolvin0 joshuacolvin0 merged commit c03fbe6 into OffchainLabs:master Jan 16, 2025
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joshuacolvin0 joshuacolvin0 joshuacolvin0 approved these changes

@eljobe eljobe eljobe approved these changes

Assignees
No one assigned
Labels
design-approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@thirdkeyword @CLAassistant @joshuacolvin0 @eljobe