Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test flatCallTracer on Arbitrum blocks inside existing tests #2676

Open
wants to merge 14 commits into
base: master
Choose a base branch
from

Conversation

amsanghi
Copy link
Contributor

@amsanghi amsanghi commented Sep 13, 2024

Fixes : NIT-2599
Test tracing retryables, deposit, system internal txs, and normal txs

For now at least, we are just not testing what the result is, just that it succeeds and doesn't return an error is main objective

@cla-bot cla-bot bot added the s Automatically added by the CLA bot if the creator of a PR is registered as having signed the CLA. label Sep 13, 2024
@amsanghi amsanghi marked this pull request as ready for review September 13, 2024 15:45
eljobe
eljobe previously approved these changes Jan 15, 2025
Copy link
Member

@eljobe eljobe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
design-approved s Automatically added by the CLA bot if the creator of a PR is registered as having signed the CLA.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants