Improve Issues Around Waiting for Safe Txs #719
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rauljordan
commented
Jan 2, 2025
| @@ -167,7 +168,7 @@ func (cc *challengeConfirmer) beginConfirmationJob( | |||
| } | |||
|
|
|||
| onchainInheritedTimer, err := retry.UntilSucceeds(ctx, func() (protocol.InheritedTimer, error) { | |||
| timer, innerErr := royalRootEdge.SafeHeadInheritedTimer(ctx) | |||
| timer, innerErr := royalRootEdge.LatestInheritedTimer(ctx) | |||
There was a problem hiding this comment.
The internal call to the solidity will use the configured block number, so it will still use safe underneath the hood if the user desires
There was a problem hiding this comment.
I feel like this would be a good candidate for some in-code documentation (a.k.a. a comment.)
eljobe
approved these changes
Jan 3, 2025
| @@ -167,7 +168,7 @@ func (cc *challengeConfirmer) beginConfirmationJob( | |||
| } | |||
|
|
|||
| onchainInheritedTimer, err := retry.UntilSucceeds(ctx, func() (protocol.InheritedTimer, error) { | |||
| timer, innerErr := royalRootEdge.SafeHeadInheritedTimer(ctx) | |||
| timer, innerErr := royalRootEdge.LatestInheritedTimer(ctx) | |||
There was a problem hiding this comment.
I feel like this would be a good candidate for some in-code documentation (a.k.a. a comment.)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a bug in the functions
waitForTxToBeSafeinside the BoLD repo. These functions used to check that a tx receipt has passed a configured,safeblock number. However, in a bad merge, it was edited to just compare againstlatest, which was incorrect. This led to a variety of UX issues in the BoLD v2 testnet and more egregious errors around attempting to send a ton of timer update txs at the end of a challenge.This PR also fixes the DB methods to use
latestblock number, as it is important our DB captures all data that is posted, even if it is reorged later. The DB does not need to be reorg safe as it is purely for informational purposes and data analysis. We also a removed a method to fetch the latest confirmed assertion via the rest API, as this can easily be retrieved via other means. The reason it was removed is because it was using several methods that were hard to configure the block number for, and it is just unnecessary in general.