Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide UI updates on save #213

Merged
merged 2 commits into from
Nov 20, 2023
Merged

Provide UI updates on save #213

merged 2 commits into from
Nov 20, 2023

Conversation

matt-richardson
Copy link
Contributor

Background

The code has always been in here to show a status message on save, but I never managed to get it working.
I decided to tackle it today.

Results

We now:

  • show a message after save
  • reload after a successful save

These changes inspired by the teamcity-priority queue plugin (especially createPriorityClass.jsp and priorityClass.js).

After

image

How to review this PR

Pre-requisites

  • I have considered informing or consulting the right people
  • I have considered appropriate testing for my change.

Copy link

@akirayamamoto akirayamamoto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks similar to this other one.

@matt-richardson matt-richardson merged commit bdb91e6 into main Nov 20, 2023
@matt-richardson matt-richardson deleted the mattr/rsb/save-status branch November 20, 2023 02:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants