Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add resource requests for NFS & Agent containers #57

Merged
merged 4 commits into from
Feb 9, 2024

Conversation

APErebus
Copy link
Contributor

@APErebus APErebus commented Feb 7, 2024

To be good Kubernetes citizens, we need to set resource requests for our containers.

Based on testing on an AKS cluster, these limits seem quite reasonable

Shortcut story: [sc-70554]

NFS

CPU

image

Memory

image

Agent

CPU

image

Memory

image

Copy link

changeset-bot bot commented Feb 7, 2024

⚠️ No Changeset found

Latest commit: e100259

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

This pull request has been linked to Shortcut Story #70554: Add resourcing requirements for the containers & jobs.

@APErebus
Copy link
Contributor Author

APErebus commented Feb 8, 2024

I will update this PR with the Tentacle container that contains the job resource requests

Copy link
Contributor

@flin-8 flin-8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@APErebus APErebus merged commit 189042a into main Feb 9, 2024
2 checks passed
@APErebus APErebus deleted the ap/k8s-resource-requests branch April 30, 2024 05:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants