Rename and re-organize resources #45
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
APErebus
commented
Jan 22, 2024
There was a problem hiding this comment.
I need to update the versioning workflow to also update the package-lock.json so it doesn't keep being added to PR's
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Makes some significant changes to the names of resources.
The key change is the "base" name is now
octopus-agent, rather than.Chart.Name(kubernetes-tentacle).We also now don't have a "fullname", which included the release name. This seemed pointless because as almost every resources is in the namespace, then the extra release name wasn't helping.
The only scenario we have this is is for cluster-wide resources (cluster role & cluster role bindings)
I also just cleaned up filenames, split files to one resource per-file and general cleanup