Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Major] Svelte 5 Migration #78

Merged
merged 12 commits into from
Dec 11, 2024
Merged

[Major] Svelte 5 Migration #78

merged 12 commits into from
Dec 11, 2024

Conversation

bertybot
Copy link
Collaborator

Svelte 5 Runes Upgrade

  • Updated Package to use new Svelte 5 runes syntax
  • Updated code to use Svelte Actions for client side only code.
  • Added layout parameter for Image for more options of how the image is displayed on the page
  • Updated all dependencies
  • Updated srcset algorithm to pick more common device sizes and also support larger devices.
  • You can now pass all HTML Image attributes & events to the Image component.
  • FadeIn for image is now purely CSS you can edit the transition property with css variable --graph-image-transition

I don't have access to the .env file for the demo so may need to hold of merging this until I can test it a bit more

@vercel Vercel
Copy link

vercel bot commented Dec 10, 2024

@bertybot2 is attempting to deploy a commit to the obiemunoz's projects Team on Vercel.

A member of the Team first needs to authorize it.

@vercel Vercel
Copy link

vercel bot commented Dec 10, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
graph-image ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 11, 2024 7:12pm

@ObieMunoz
Copy link
Owner

Thanks @bertybot I'll try to start looking over this tomorrow

@bertybot2
Fix Types to extend image
3c08299 
Fix Eager images
remove unused props
add accessibility
ObieMunoz
ObieMunoz reviewed Dec 11, 2024
View reviewed changes
package.json Outdated Show resolved Hide resolved
ObieMunoz
ObieMunoz reviewed Dec 11, 2024
View reviewed changes
turbo.json Show resolved Hide resolved
@bertybot @ObieMunoz
Update turbo.json
af55253 
Co-authored-by: Obie Munoz <[email protected]>
@ObieMunoz
Copy link
Owner

ObieMunoz commented Dec 11, 2024 •
edited
Loading

graph-image-demo:build: error during build:
graph-image-demo:build: Error [ERR_MODULE_NOT_FOUND]: Cannot find package '@sveltejs/adapter-vercel' imported from /vercel/path0/demo/svelte.config.js

@ObieMunoz ObieMunoz merged commit 8e1537c into ObieMunoz:main Dec 11, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ObieMunoz ObieMunoz ObieMunoz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bertybot @ObieMunoz @bertybot2