decode JSON on empty string should not raise exception

OXID-eSales · Jan 10, 2025 · 32857fe · 32857fe
1 parent ecfd841
commit 32857fe
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/src/Controller/ProxyController.php b/src/Controller/ProxyController.php
@@ -129,7 +129,7 @@ public function createGooglePayOrder()
         $this->setPayPalPaymentMethod($paymentId);
         $basket = Registry::getSession()->getBasket();
 
-        if ($basket && $basket->getItemsCount() === 0) {
+        if ($basket->getItemsCount() === 0) {
             $this->outputJson(['ERROR' => 'No Article in the Basket']);
         }
 
@@ -231,7 +231,7 @@ public function createGooglePayOrder()
      */
     public function approveOrder()
     {
-        $data = json_decode(file_get_contents('php://input'), true, 512, JSON_THROW_ON_ERROR);
+        $data = json_decode(file_get_contents('php://input'), true);
         $orderId = (string) Registry::getRequest()->getRequestEscapedParameter('orderID');
         $sessionOrderId = PayPalSession::getCheckoutOrderId();
         if (!empty($data['orderID']) && $orderId === '') {