Skip to content

Commit

Permalink
Fix parameter names to fit data provider given keys
Browse files Browse the repository at this point in the history
As of named parameters introduction, this is something phpunit wants to use as well most likely, so argument names should fit the data providers.
  • Loading branch information
Sieg committed Apr 23, 2024
1 parent c389ec5 commit 31f23e4
Showing 1 changed file with 4 additions and 4 deletions.
8 changes: 4 additions & 4 deletions tests/Unit/Service/NamingServiceTest.php
Original file line number Diff line number Diff line change
Expand Up @@ -122,10 +122,10 @@ public static function getUniqueFilenameDataProvider(): \Generator
}

/** @dataProvider validationGoodFileNamesDataProvider */
public function testValidateGoodFilename(string $goodFilename): void
public function testValidateGoodFilename(string $fileName): void
{
$sut = $this->getSut();
$this->assertTrue($sut->validateFileName($goodFilename));
$this->assertTrue($sut->validateFileName($fileName));
}

public static function validationGoodFileNamesDataProvider(): \Generator
Expand All @@ -134,12 +134,12 @@ public static function validationGoodFileNamesDataProvider(): \Generator
}

/** @dataProvider validationBadFileNamesDataProvider */
public function testValidateBadFilename(string $badFilename): void
public function testValidateBadFilename(string $fileName): void
{
$sut = $this->getSut();

$this->expectException(WrongFileTypeException::class);
$sut->validateFileName($badFilename);
$sut->validateFileName($fileName);
}

public static function validationBadFileNamesDataProvider(): \Generator
Expand Down

0 comments on commit 31f23e4

Please sign in to comment.