OXDEV-7845 Add phpcs and phpstan to ci run

Signed-off-by: Anton Fedurtsya <[email protected]>
OXID-eSales · Apr 25, 2024 · 09e64cb · 09e64cb
1 parent a1b8a69
commit 09e64cb
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 3 deletions.
diff --git a/.github/oxid-esales/module-medialibrary.yml b/.github/oxid-esales/module-medialibrary.yml
@@ -39,6 +39,8 @@ runscript: &runscript
       [
         "medialibrary:tests-unit",
         "medialibrary:tests-integration",
+        "medialibrary:phpstan",
+        "medialibrary:phpcs",
       ]
   medialibrary:
     path: 'vendor/{{ $org}}/{{ $name }}'

diff --git a/.github/workflows/push_module_71x.yml b/.github/workflows/push_module_71x.yml
@@ -6,7 +6,7 @@ on:
       - 'b-7.1.x**'
 
 jobs:
-  erp_php82_mysql80:
+  php82_mysql80:
     uses: oxid-eSales/github-actions/.github/workflows/universal_workflow_light.yml@v4
     with:
       testplan: '~/defaults/7.1.x.yml,~/defaults/php8.2_mysql8.0_only.yml,~/module-medialibrary.yml,~/_custom.yml'

diff --git a/src/Application/Controller/Admin/MediaController.php b/src/Application/Controller/Admin/MediaController.php
@@ -82,7 +82,6 @@ public function upload(): void
         $responseService = $this->getService(ResponseInterface::class);
 
         $sId = null;
-        $sFileName = '';
         $sThumb = '';
 
         try {
@@ -121,7 +120,7 @@ public function upload(): void
             $responseService->responseAsJson([
                 'success' => true,
                 'id' => $sId,
-                'file' => $sFileName,
+                'file' => $sFileName ?? '',
                 'filetype' => $sFileType ?? '',
                 'filesize' => $sFileSize ?? '',
                 'imagesize' => $sImageSize ?? '',