Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In this PR I update
otoole
to fix failing tests on Windows.Specifically this includes:
int
asint64
data types when the config file is first read in. Im not sure why, but on Windows pandas seems to setint
asint32
, while on Linux it will set it asint64
(or is just not concerned aboutint32
vs.int64)
. Anyways,int64
is explicitly set nowint64
forint
datatypes in the results package (note, the config file dtypes are not accessible here)int64
forread_strategies
of solverslineterminator
argument as\n
when writing to csv or datafiles, as Windows will default to\r\n
. More information hereNamedTemporaryFile
calls in the tests on Windows. As this Stack Overflow comment and this Python docs states, to open aNamedTemporaryFile
on Windows, you must setdelete=False
and then explicitly close and delete the file. Therefore, I have wrapped allNamedTemporaryFile
calls in tests intry
finally
blocks, where thefinally
code closes and deletes the temporary file.Issue Ticket Number
Closes #202
Documentation
na