Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Windows: Apply OSGeo4W patches for Postgres (backport) #5005

Merged

Conversation

neteler
Copy link
Member

@neteler neteler commented Jan 29, 2025

Backport of #4996 to G84 branch

Co-authored-by: @echoix

@neteler neteler added bug Something isn't working windows Microsoft Windows specific CI Continuous integration labels Jan 29, 2025
@neteler neteler added this to the 8.4.1 milestone Jan 29, 2025
@neteler neteler requested a review from echoix January 29, 2025 10:30
@neteler neteler self-assigned this Jan 29, 2025
@echoix
Copy link
Member

echoix commented Jan 29, 2025

I know that for the grass (non grass-dev), the patches were different. Are we fine to place this change as-is?

@nilason
Copy link
Contributor

nilason commented Jan 29, 2025

I know that for the grass (non grass-dev), the patches were different. Are we fine to place this change as-is?

I would think so.

checking whether to use PostgreSQL... "yes"
checking for location of PostgreSQL includes... /c/OSGeo4W/include
checking for libpq-fe.h... yes
checking for location of PostgreSQL library... /d/a/grass/grass/mswindows/osgeo4w/lib
checking for PQsetdbLogin in -lpq... yes
checking for PQcmdTuples in -lpq... yes

...

  PostgreSQL support:         yes

@neteler neteler merged commit ec54064 into OSGeo:releasebranch_8_4 Jan 29, 2025
26 checks passed
@neteler neteler deleted the osgeo4w-postgres-patch_backport branch January 29, 2025 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working CI Continuous integration windows Microsoft Windows specific
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants