Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

r.sim.water: build topology for vector output #4969

Merged
merged 1 commit into from
Jan 22, 2025

Conversation

metzm
Copy link
Contributor

@metzm metzm commented Jan 21, 2025

Topology was not built for the vector output walkers_output. This is within GRASS not a problem, but the QGIS interface fails because a vector without topology can not be exported with v.out.ogr, consequently QGIS complains about a missing output. With this PR, topology is built for the vector output which should not have any effects otherwise because it is only a points vector with simple topology.

@metzm metzm added enhancement New feature or request QGIS Highly related to QGIS or specific to QGIS vector Related to vector data processing C Related code is in C backport to 8.4 PR needs to be backported to release branch 8.4 labels Jan 21, 2025
@metzm metzm added this to the 8.5.0 milestone Jan 21, 2025
@metzm metzm requested a review from neteler January 21, 2025 17:04
@github-actions github-actions bot added raster Related to raster data processing module labels Jan 21, 2025
@neteler
Copy link
Member

neteler commented Jan 21, 2025

FYI
At time our CI fails due to "Bitbucket is experiencing an incident" leading the step scripts/g.extension/testsuite/test_addons_download.py to fail.

Copy link
Member

@neteler neteler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me as it fixes a compatibility issue to other software.

@echoix echoix merged commit fb0882c into OSGeo:main Jan 22, 2025
28 checks passed
@neteler neteler removed the backport to 8.4 PR needs to be backported to release branch 8.4 label Jan 22, 2025
@neteler neteler modified the milestones: 8.5.0, 8.4.1 Jan 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C Related code is in C enhancement New feature or request module QGIS Highly related to QGIS or specific to QGIS raster Related to raster data processing vector Related to vector data processing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants