Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding flag (f/b) to predictive column name #12

Merged
merged 1 commit into from
May 13, 2024

Conversation

Jday7879
Copy link
Collaborator

@Jday7879 Jday7879 commented May 13, 2024

Summary

Add your summary here - keep it brief, to the point, and in plain English.

Minor bug fixes in flag_matched_pair_merge and flag_matched_pair_shift

Checklists

This pull request meets the following requirements:

  • installable with all dependencies recorded
  • runs without error
  • follows PEP8 and project specific conventions
  • appropriate use of comments, for example no descriptive comments
  • functions documented using Numpy style docstings
  • assumptions and decisions log considered and updated if appropriate
  • unit tests have been updated to cover essential functionality for a reasonable range of inputs and conditions
  • other forms of testing such as end-to-end and user-interface testing have been considered and updated as required
  • tests suite passes (locally as a minimum)
  • peer reviewed with review recorded

If you feel some of these conditions do not apply for this pull request, please
add a comment to explain why.

@Jday7879 Jday7879 requested a review from AntonZogk May 13, 2024 11:33
Copy link
Collaborator

@AntonZogk AntonZogk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Jday7879 all looking great, nothing to add

@Jday7879 Jday7879 merged commit d2d63bf into main May 13, 2024
2 checks passed
@Jday7879 Jday7879 deleted the 318-forward-match-bug-fixes branch May 13, 2024 13:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants