Update Slack File Upload API #177
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Yuyutsu Rai <[email protected]>
Signed-off-by: Yuyutsu Rai <[email protected]>
Yuyuutsu
changed the title
petechd
reviewed
Dec 12, 2024
| response = client.files_upload( | ||
| channels=f"#{slack_channel}", | ||
| response = client.files_upload_v2( | ||
| channel=slack_channel, | ||
| content=content, | ||
| filetype=file_type, |
There was a problem hiding this comment.
I got these errors when running it:
UserWarning: The filetype parameter is no longer supported. Please remove it from the arguments.
warnings.warn("The filetype parameter is no longer supported. Please remove it from the arguments.")
Slack notification errored
Error: channel_not_found
There was a problem hiding this comment.
Sorry for the late reply, my GPG key was expired but it is now updated 👍
There was a problem hiding this comment.
It's also the channel that is causing the error.
There was a problem hiding this comment.
Updated and Working 🤞
petechd
reviewed
Dec 17, 2024
VirajP1002
reviewed
Jan 3, 2025
petechd
approved these changes
Jan 6, 2025
petechd
approved these changes
Jan 9, 2025
VirajP1002
approved these changes
Jan 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the context of this PR?
This PR is to update the deprecated Slack File Upload method which will be replaced March 2025.
Slack Client has been replaced by Slack's Python SDK. Migration To SDK
Benchmark Pipelines PR: https://github.com/ONSdigital/eq-pipelines/pull/656/files#diff-69a76bccc721b7c5ce6002eded0909122e79faea147db3efd53e1867a3b682a8
How to review