-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add session/download-pdf endpoints and add graph to represent values #164
Conversation
Do we want to fix the other places where we cast integer on floats and round up/down instead (as part of this PR, since we are already here)? Are there other places that still do that? Do other devs have any thoughts? |
I'm happy to add those in as it removes the rounding issue we talked about. These changes are minor and I guess it would be potentially tweaking the graph values? So I think it's somewhat relevant to this PR, but yep, let's see what the other devs think |
…hamark outputs and update tests
We should bump the test coverage as part of this PR as I think we are up to 85% now 🎉 |
What is the context of this PR?
To update the benchmark outputs in order for us to monitor and highlight the performance of more intensive endpoints by including
session
anddownload-pdf
.benchmark_stats
has been provisioned with the 99th percentiles for thesession
anddownload-pdf
endpoints. In order to achieve this, the happy path has been updated to includedownload-pdf
such that the csv file created when running the benchmark contains the percentiles for this endpoint. The output "string" of the benchmark stats has been updated to include the new metrics for both Github and non-Github outputs.visualise_results
has been updated to support the new metrics. Currently, as the 99th percentiles for bothsession
anddownload-pdf
are significantly larger than the original figures, it was decided that outputting 2 graphs was the most appropriate solution. Thus, 2 dataframes have been created, one for the original percentiles and a new one for the additional metrics. The "image" of the graphs created use subplots to place both graphs created next to each other.Various tests have been updated and parametrised. In addition to this
conftest
was updated to include more fixtures that support the new endpoints.How to review
visualise_results
script