Spike: Enable minify HTML for Runner #158
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
berroar
reviewed
Jun 25, 2024
There was a problem hiding this comment.
As discussed I have had a read through and looks like the findings here seem to align with the findings we did on the initial spike when we investigated enabling minify. As there are no visible benefits and some minor negative impacts I cannot at the moment see a reason to enable minify as we should expect to see performance improve when it is enabled. Will prob need to document in the decision log (providing other devs agree).
berroar
approved these changes
Jun 27, 2024
VirajP1002
approved these changes
Jul 4, 2024
petechd
approved these changes
Jul 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the context of this PR?
Run a performance investigation to assess whether we can re-enable the minification of HTML in Runner.
How to review
summary.mdfile - Is the investigation okay and does it answer our questions about enabling HTML minify?Jira