Update payload to v2 layout to run daily benchmark #154
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
petechd
approved these changes
Apr 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the context of this PR?
The daily benchmark needs to be updated to use the
v2schema launch payload format to allow a successful run, following a recent Runner change to remove all traces of thev1schema launch.The payload has now been altered to align with the example
v2schema found in the ons-schema-definitions repo (excluding thesds_dataset_id)How to review
Run the below benchmarks from this repo root, they should now run successfully. A follow-up ticket will be raised to investigate possibly removing the other JSON requests, as some appear to no longer be in use:
pipenv run ./run.sh requests/test_benchmark_business_happy_path.jsonpipenv run ./run.sh requests/test_benchmark_business_unhappy_path.jsonpipenv run ./run.sh requests/test_checkbox.jsonJira