Fix unhappy path benchmark schema journey #145
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VirajP1002
changed the title
petechd
approved these changes
Jan 4, 2024
VirajP1002
deleted the
prevent-duplicate-answer-ids-across-different-list-collectors
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the context of this PR?
The unhappy benchmark journey when run against main was where the following error was reported on the set-min-max-block page: Expected a (200) but got a (404) back when getting page: /questionnaire/people/{person_2}/set-min-max-block/?resume=True').
To fix this, a similar journey was followed to recreate an updated requests files and when running the benchmark tests locally, the error message does not appear.
How to review
Run the benchmark tests using
make runensuring the file in the command is changed fromtest_checkbox.jsontotest_benchmark_business_unhappy_path.json