-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support business prepop survey launch #11
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…les. Handle unit data
… directly. Small tidy up
2 tasks
berroar
reviewed
Apr 2, 2024
berroar
reviewed
Apr 2, 2024
berroar
reviewed
Apr 2, 2024
berroar
reviewed
Apr 2, 2024
petechd
reviewed
Apr 3, 2024
liamtoozer
commented
Apr 3, 2024
…Makefile command.
…cores from folder path names used in 'title' field
berroar
reviewed
Apr 23, 2024
berroar
approved these changes
May 2, 2024
petechd
approved these changes
May 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the context of this PR?
We want to be able to launch business schemas that use supplementary data. This service has been altered to serve SDS metadata and unit data back to the caller.
A similar pattern to cache the mock unit data has been used, as in our mock CIR API. Happy to change this pattern to something else, as there isn't much SDS mock data at the moment. We could simply preload the data at startup instead, but see what you think might be best for now.
For this PR, we now do the following:
dataset_id
for each metadata chunk (similar to the mock CIR repo for its data)How to review
make load-mock-unit-data
to pull down the example unit data from the SDS schema repo/v1/dataset_metadata?survey_id=014&period_id=1
and/v1/unit_data?dataset_id=d8afa921-1305-d553-d2c6-955a6db2cc2d&identifier=1
. Ensure that the data returned is as expectedNote: As mentioned in the comments, Prodcom and BRES/BRS schemas cannot currently be tested
Jira ticket