Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update eq-translations to 4.9.2 #246

Merged
merged 11 commits into from
Jun 14, 2024
Merged

Conversation

rmccar
Copy link
Contributor

@rmccar rmccar commented Jun 11, 2024

What is the context of this PR?

This updates the eq-translations dependancy to version 4.9.2 and recreates the lockfile. There was a warning when recreating the lockfile and to fix that I have also added a package folder which is what has been done in some other repos to solve this.

How to review

  • Tests pass

Checklist

  • eq-translations updated to support any new schema keys which need translation

@petechd
Copy link
Contributor

petechd commented Jun 12, 2024

We should probably mention actions update in PR description or ideally in the title (if we want to keep these actions updates in this PR since it seems irrelevant), also, don't main and release yamls need checkout updates as well?

@rmccar
Copy link
Contributor Author

rmccar commented Jun 12, 2024

We should probably mention actions update in PR description or ideally in the title (if we want to keep these actions updates in this PR since it seems irrelevant), also, don't main and release yamls need checkout updates as well?

Ive added more information the description on that change and also added the updates for the main and release workflows. But I can take the change out if wanted. I updated them to see if it helped with the warnings/errors I was seeing and just left them in because I thought it would be good to update them anyway but I understand that is a separate change really.

@petechd
Copy link
Contributor

petechd commented Jun 12, 2024

We should probably mention actions update in PR description or ideally in the title (if we want to keep these actions updates in this PR since it seems irrelevant), also, don't main and release yamls need checkout updates as well?

Ive added more information the description on that change and also added the updates for the main and release workflows. But I can take the change out if wanted. I updated them to see if it helped with the warnings/errors I was seeing and just left them in because I thought it would be good to update them anyway but I understand that is a separate change really.

Probably worth taking it out since there is a card for it: https://jira.ons.gov.uk/browse/ECI-1263

@rmccar
Copy link
Contributor Author

rmccar commented Jun 12, 2024

We should probably mention actions update in PR description or ideally in the title (if we want to keep these actions updates in this PR since it seems irrelevant), also, don't main and release yamls need checkout updates as well?

Ive added more information the description on that change and also added the updates for the main and release workflows. But I can take the change out if wanted. I updated them to see if it helped with the warnings/errors I was seeing and just left them in because I thought it would be good to update them anyway but I understand that is a separate change really.

Probably worth taking it out since there is a card for it: jira.ons.gov.uk/browse/ECI-1263

We should probably mention actions update in PR description or ideally in the title (if we want to keep these actions updates in this PR since it seems irrelevant), also, don't main and release yamls need checkout updates as well?

Ive added more information the description on that change and also added the updates for the main and release workflows. But I can take the change out if wanted. I updated them to see if it helped with the warnings/errors I was seeing and just left them in because I thought it would be good to update them anyway but I understand that is a separate change really.

Probably worth taking it out since there is a card for it: jira.ons.gov.uk/browse/ECI-1263

Id probably leave it in as the work is already done and it reduces the work needed for that card but ok Ill take it out. Ill also mention the need for checkout to be updated on that card

@rmccar rmccar merged commit 6fd04ad into main Jun 14, 2024
3 checks passed
@rmccar rmccar deleted the update-eq-translations-to-4.9.2 branch June 14, 2024 07:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants