Prevent repeating GCS referencing static CS with answers repeating for same list #227
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
petechd
reviewed
Dec 11, 2023
petechd
reviewed
Dec 11, 2023
berroar
reviewed
Dec 12, 2023
app/validators/blocks/grand_calculated_summary_block_validator.py
Outdated
Show resolved
Hide resolved
petechd
approved these changes
Dec 12, 2023
petechd
reviewed
Dec 12, 2023
tests/validators/blocks/test_grand_calculated_summary_block_validator.py
Outdated
Show resolved
Hide resolved
MebinAbraham
approved these changes
Dec 14, 2023
app/validators/blocks/grand_calculated_summary_block_validator.py
Outdated
Show resolved
Hide resolved
katie-gardner
deleted the
gcs-in-repeat-with-static-cs-repeating-answers
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the context of this PR?
This PR prevents a repeating Grand Calculated Summary from including a static Calculated Summary that has repeating answers for the same list. It is in place to support the corresponding runner PR
This included some changes to
questionnaire_schemato include a way of looking up a list name by answer id. I wasn't aware of another way to easily do this.How to review
Check over the added invalid test schema and make sure it is correctly covering the case that the card mentions to exclude. GCS should allow a static CS repeating over a different list, but not the same one. Look for any possible edge cases this has missed.
Checklist