Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update launcher to support multiple schema versions #84

Merged
merged 11 commits into from
Jul 29, 2024

Conversation

VirajP1002
Copy link
Contributor

@VirajP1002 VirajP1002 commented Jun 27, 2024

What is the context of this PR?

Given the schema_version now has multiple versions, Launcher needed to be updated to support this where the data would update dynamically when choosing a different sds_dataset_id. Previously, when changing versions, it would add the dataset keys to the existing ones resulting in repeated fields. The changes made to the JS and HTML prevents that from occurring.

Ensure you use the Mock SDS PR when reviewing this to get the multiple schema versions for Supplementary Data. Make sure you use the Runner PR too, to ensure that you can open schemas with multiple versions.

How to review

  • Ensure the changes make sense
  • Ensure you can open schemas
  • Ensure you select a different sds_dataset_id and the fields update correctly.

@VirajP1002 VirajP1002 changed the title Update launcher to support v2 schemas and to handle multiple versions Update launcher to support multiple schema versions Jun 28, 2024
static/javascript/launch.js Outdated Show resolved Hide resolved
static/javascript/launch.js Outdated Show resolved Hide resolved
static/javascript/launch.js Outdated Show resolved Hide resolved
static/javascript/launch.js Outdated Show resolved Hide resolved
templates/launch.html Outdated Show resolved Hide resolved
static/javascript/launch.js Outdated Show resolved Hide resolved
@VirajP1002 VirajP1002 merged commit 2ec1391 into main Jul 29, 2024
3 checks passed
@VirajP1002 VirajP1002 deleted the support-v2-schemas branch July 29, 2024 12:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants