-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update launcher to support multiple schema versions #84
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VirajP1002
changed the title
Update launcher to support v2 schemas and to handle multiple versions
Update launcher to support multiple schema versions
Jun 28, 2024
2 tasks
rmccar
reviewed
Jul 9, 2024
rmccar
reviewed
Jul 9, 2024
rmccar
reviewed
Jul 9, 2024
rmccar
reviewed
Jul 9, 2024
rmccar
reviewed
Jul 9, 2024
rmccar
reviewed
Jul 16, 2024
rmccar
approved these changes
Jul 22, 2024
petechd
approved these changes
Jul 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the context of this PR?
Given the
schema_version
now has multiple versions, Launcher needed to be updated to support this where the data would update dynamically when choosing a differentsds_dataset_id
. Previously, when changing versions, it would add the dataset keys to the existing ones resulting in repeated fields. The changes made to the JS and HTML prevents that from occurring.Ensure you use the Mock SDS PR when reviewing this to get the multiple schema versions for Supplementary Data. Make sure you use the Runner PR too, to ensure that you can open schemas with multiple versions.
How to review
sds_dataset_id
and the fields update correctly.