Merge pull request #3115 from ONSdigital/EAR-2414-created-date-incorr…

…ectly-showing-modified-date EAR-2414 - Created date incorrectly showing modified date
ONSdigital · May 23, 2024 · d83076a · d83076a
2 parents 774b063 + 098dfde
commit d83076a
Show file tree

Hide file tree

Showing 4 changed files with 38 additions and 5 deletions.
diff --git a/cloudbuild-author-tests.yaml b/cloudbuild-author-tests.yaml
@@ -26,6 +26,6 @@ steps:
         exit $(( 1 - $result ))
     id: unit_tests
     entrypoint: /bin/ash
-timeout: 1200s
+timeout: 1800s
 options:
   machineType: E2_HIGHCPU_8
diff --git a/eq-author-api/db/baseQuestionnaireSchema.js b/eq-author-api/db/baseQuestionnaireSchema.js
@@ -61,7 +61,20 @@ const baseQuestionnaireFields = {
   locked,
 };
 
+const saveQuestionnaireFields = {
+  id,
+  isPublic,
+  title,
+  type,
+  shortTitle,
+  publishStatus,
+  introduction,
+  editors,
+  locked,
+};
+
 module.exports = {
   baseQuestionnaireFields,
   ...baseQuestionnaireFields,
+  saveQuestionnaireFields,
 };
diff --git a/eq-author-api/db/datastore/datastore-firestore.js b/eq-author-api/db/datastore/datastore-firestore.js
@@ -4,7 +4,10 @@ const { logger } = require("../../utils/logger");
 const { pick } = require("lodash/fp");
 const { omit } = require("lodash");
 const { removeEmpty } = require("../../utils/removeEmpty");
-const { baseQuestionnaireFields } = require("../baseQuestionnaireSchema");
+const {
+  baseQuestionnaireFields,
+  saveQuestionnaireFields,
+} = require("../baseQuestionnaireSchema");
 const {
   questionnaireCreationEvent,
   historyCreationForImport,
@@ -32,6 +35,14 @@ const BASE_FIELDS = [
 
 const justListFields = pick(BASE_FIELDS);
 
+const SAVE_FIELDS = [
+  ...Object.keys(saveQuestionnaireFields),
+  "updatedAt",
+  "history",
+];
+
+const justListSaveFields = pick(SAVE_FIELDS);
+
 const saveSections = (parentDoc, sections) =>
   Promise.all(
     sections.map((section, position) =>
@@ -271,8 +282,7 @@ const saveQuestionnaire = async (changedQuestionnaire) => {
         "Unable to save questionnaire; cannot find required field: ID (from saveQuestionnaire)"
       );
     }
-    const createdAt = new Date();
-    const updatedAt = createdAt;
+    const updatedAt = new Date();
 
     const originalQuestionnaire = await getQuestionnaire(id);
 
@@ -297,7 +307,7 @@ const saveQuestionnaire = async (changedQuestionnaire) => {
 
     const baseDoc = db.collection("questionnaires").doc(id);
     await baseDoc.update({
-      ...justListFields(updatedQuestionnaire),
+      ...justListSaveFields(updatedQuestionnaire),
       updatedAt,
     });
 

diff --git a/eq-author-api/db/datastore/datastore-firestore.test.js b/eq-author-api/db/datastore/datastore-firestore.test.js
@@ -258,6 +258,16 @@ describe("Firestore Datastore", () => {
       });
       expect(updatedAt !== savedQuestionnaire.updatedAt).toBeTruthy();
     });
+
+    it("Should not update the 'createdAt' property", async () => {
+      const createdAt = questionnaire.createdAt;
+      const savedQuestionnaire = await saveQuestionnaire({
+        id: "123",
+        title: "Updated questionnaire title",
+        ...questionnaire,
+      });
+      expect(createdAt === savedQuestionnaire.createdAt).toBeTruthy();
+    });
   });
 
   describe("Getting a list of questionnaires", () => {