tool: rewrite suricatasc and suricatactl in rust - v9 #12504
+1,450
−1,009
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a re-implementation of suricatasc program in Rust that attempts to be a 100% drop-in replacement.
As we have 2 Windows builds, do one using the release-style distribution file.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #12504 +/- ##
==========================================
+ Coverage 80.56% 80.58% +0.01%
==========================================
Files 925 926 +1
Lines 259292 259295 +3
==========================================
+ Hits 208906 208946 +40
+ Misses 50386 50349 -37
Flags with carried forward coverage won't be shown. Click here to find out more. |
|
Information: QA ran without warnings. Pipeline 24441 |
inashivb
reviewed
Jan 31, 2025
The RPM builds? Unfortunately those can only be fixed after merge. |
Thanks. Missed that. Most users don't need to know what these tools are written in, just how to use them :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continuation of #9817.
Replaces suricatasc and suricatactl with Rust variants removing python from our
distributed code (except suricata-update).
These now pass CI as some CI tests now use suricatasc where they didn't in the
previous version.
These should also be pure drop-in replacements.
Usually rewrites are a bad idea, but these are small, and in our core language
set, and may inspire us to write new more interesting tooling in the future :)
Ticket: https://redmine.openinfosecfoundation.org/issues/6287