Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prefilter/v1 #12477

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from
Draft

Prefilter/v1 #12477

wants to merge 2 commits into from
+26 −14

Conversation

victorjulien
Copy link
Member

@victorjulien victorjulien marked this pull request as draft January 25, 2025 09:34
@codecov Codecov
Copy link

codecov bot commented Jan 25, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 90.47619% with 2 lines in your changes missing coverage. Please review.

Project coverage is 80.52%. Comparing base (d63ad75) to head (283c053).

Additional details and impacted files 
@@            Coverage Diff             @@
##           master   #12477      +/-   ##
==========================================
- Coverage   80.52%   80.52%   -0.01%     
==========================================
  Files         923      923              
  Lines      259176   259187      +11     
==========================================
- Hits       208708   208704       -4     
- Misses      50468    50483      +15
Flag Coverage Δ
fuzzcorpus 56.06% <90.47%> (+<0.01%) ⬆️
livemode 19.41% <33.33%> (-0.01%) ⬇️
pcap 44.22% <47.61%> (+0.02%) ⬆️
suricata-verify 63.30% <90.47%> (-0.03%) ⬇️
unittests 58.45% <80.95%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@victorjulien victorjulien marked this pull request as ready for review January 25, 2025 15:18
@suricata-qa
Copy link

Information: QA ran without warnings.

Pipeline 24357

@victorjulien victorjulien marked this pull request as draft January 25, 2025 18:08
@victorjulien
detect/prefilter: fix prefilter setup
b8be61e 
If `prefilter` is used it should override automatic fast pattern
selection.

Fixes: d6b5692 ("detect: set mpm/prefilter during signature parsing")

Ticket: OISF#7523.
@victorjulien
detect: remove unused SignatureInitData member
283c053
@suricata-qa
Copy link

Information: QA ran without warnings.

Pipeline 24360

@suricata-qa
Copy link

Information: QA ran without warnings.

Pipeline 24361

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@victorjulien @suricata-qa