Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding handleROIThresholding to utility module of tmtv extension. #4715

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ashik-trenser
Copy link

Context

  • Adding the the function handleROIThresholding in to the utility module of tmtv extension in order to make the function available for a custom panel.

Changes & Results

  • Added a getUtilityModule function to the index file of tmtv extension's index file.
  • Added handleROIThresholding function to the utility module under the name 'common'.

Testing

Checklist

PR

  • My Pull Request title is descriptive, accurate and follows the
    semantic-release format and guidelines.

Code

  • My code has been well-documented (function documentation, inline comments,
    etc.)

Public Documentation Updates

  • The documentation page has been updated as necessary for any public API
    additions or removals.

Tested Environment

  • OS: Windows 11.
  • Node version: 18.19.0
  • Browser: Chrome 131.0.6778.265

…rder to get the funtion when using a custom panel.
Copy link

netlify bot commented Jan 21, 2025

Deploy Preview for ohif-platform-docs ready!

Name Link
🔨 Latest commit 135e2ab
🔍 Latest deploy log https://app.netlify.com/sites/ohif-platform-docs/deploys/678f8564e7ddfa0008117ec6
😎 Deploy Preview https://deploy-preview-4715--ohif-platform-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Jan 21, 2025

Deploy Preview for ohif-dev ready!

Name Link
🔨 Latest commit 135e2ab
🔍 Latest deploy log https://app.netlify.com/sites/ohif-dev/deploys/678f85641badc2000898a7d9
😎 Deploy Preview https://deploy-preview-4715--ohif-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@ashik-trenser ashik-trenser marked this pull request as draft January 21, 2025 11:44
@@ -26,6 +27,16 @@ const tmtvExtension = {
extensionManager,
});
},
getUtilityModule() {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We are moving away from the utility module. You can export it in this extension and have other extensions depend on it and import it there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants