Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] feat: Start of being able to group findings table #4712

Open
wants to merge 15 commits into
base: master
Choose a base branch
from

Conversation

wayfarer3130
Copy link
Contributor

Context

When there are lots of measurements/contours, a better organization is required than simply dumping all the items into a list. This PR is the start of being able to group items in the measurements table.

Changes & Results

Testing

Checklist

PR

  • [] My Pull Request title is descriptive, accurate and follows the
    semantic-release format and guidelines.

Code

  • [] My code has been well-documented (function documentation, inline comments,
    etc.)

Public Documentation Updates

  • [] The documentation page has been updated as necessary for any public API
    additions or removals.

Tested Environment

  • [] OS:
  • [] Node version:
  • [] Browser:

Copy link

netlify bot commented Jan 20, 2025

Deploy Preview for ohif-platform-docs canceled.

Name Link
🔨 Latest commit 394f052
🔍 Latest deploy log https://app.netlify.com/sites/ohif-platform-docs/deploys/67939440fa2bba0008e72874

Copy link

netlify bot commented Jan 20, 2025

Deploy Preview for ohif-dev canceled.

Name Link
🔨 Latest commit 394f052
🔍 Latest deploy log https://app.netlify.com/sites/ohif-dev/deploys/679394403d0a8e0008bc2bc3

Copy link

cypress bot commented Jan 20, 2025

Viewers    Run #4767

Run Properties:  status check failed Failed #4767  •  git commit 394f052700: Remove wrong import
Project Viewers
Branch Review feat/measurement-table-grouping
Run status status check failed Failed #4767
Run duration 02m 48s
Commit git commit 394f052700: Remove wrong import
Committer Bill Wallace
View all properties for this run ↗︎

Test results
Tests that failed  Failures 11
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 2
Tests that did not run due to a failure in a mocha hook  Skipped 20
Tests that passed  Passing 13
View all changes introduced in this branch ↗︎

Tests for review

Failed  measurement-tracking/OHIFCornerstoneToolbar.spec.js • 1 failed test

View Output Video

Test Artifacts
OHIF Cornerstone Toolbar > checks if all primary buttons are being displayed Test Replay Screenshots Video
Failed  measurement-tracking/OHIFMeasurementPanel.spec.js • 1 failed test

View Output Video

Test Artifacts
OHIF Measurement Panel > checks if Measurements right panel can be hidden/displayed Test Replay Screenshots Video
Failed  customization/HangingProtocol.spec.js • 1 failed test

View Output Video

Test Artifacts
OHIF HP > Should display 3 up Test Replay Screenshots Video
Failed  volume/MPR.spec.js • 1 failed test

View Output Video

Test Artifacts
OHIF MPR > should not go MPR for non reconstructible displaySets Test Replay Screenshots Video
Failed  measurement-tracking/OHIFCornerstoneHotkeys.spec.js • 1 failed test

View Output Video

Test Artifacts
OHIF Cornerstone Hotkeys > checks if hotkeys "R" and "L" can rotate the image Test Replay Screenshots Video

The first 5 failed specs are shown, see all 11 specs in Cypress Cloud.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant