Feat/custom onDropHandler for viewportGrid #4641
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for ohif-dev ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for ohif-platform-docs canceled.
|
|
Can you rebase on top of the new customization service and follow what's done there please? Sorry for the inconvenience |
Jaseel-trenser
force-pushed
the
feat/custom-onDropHandler-for-viewportGrid
branch
from
651d7f7 to
6196ac2
Compare
@sedghi I’ve rebased and updated the changes based on the new customization service. |
sedghi
reviewed
Jan 24, 2025
| const updatedViewports = _getUpdatedViewports(viewportId, displaySetInstanceUID); | ||
| viewportGridService.setDisplaySetsForViewports(updatedViewports); | ||
| let dropHandlerPromise = Promise.resolve({ handled: false }); | ||
| const customOnDropHandler = customizationService.getCustomization('customOnDropHandler'); |
There was a problem hiding this comment.
you need to provide a default null in the customizations folder in the extension. Also document it in here https://docs.ohif.org/platform/services/customization-service/customizationService#customizable-parts-of-ohif
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Changes & Results
Testing
Checklist
PR
semantic-release format and guidelines.
Code
etc.)
Public Documentation Updates
additions or removals.
Tested Environment