Disable mp on weird test

oggm/params.cfg

@@ -3,6 +3,7 @@
 ### Input/Output paths. Set to ~ to default to home directory
 
 # Where OGGM will write its output
+# Can be overridden with the environment variable OGGM_WORKDIR
 working_dir =
 
 # Users can specify their own topography file if they want to.
@@ -23,12 +24,15 @@ climate_file =
 rgi_version = 62
 
 # Multiprocessing
+# Can be overridden with the environment variable OGGM_USE_MULTIPROCESSING
 use_multiprocessing = False
 # Number of processors to use (-1 = all available)
+# Can be overridden with the environment variable SLURM_JOB_CPUS_PER_NODE
 mp_processes = -1
 # To avoid race issues when using GDAL, it might be necessary to set this
 # to "true". It makes the initialisation of the pool slower, which is
 # why it is false per default
+# Can be overridden with the environment variable OGGM_USE_MP_SPAWN
 use_mp_spawn = False
 
 # Continue on error?

oggm/tests/test_utils.py

@@ -14,9 +14,6 @@
 import xarray as xr
 from numpy.testing import assert_array_equal, assert_allclose
 
-salem = pytest.importorskip('salem')
-gpd = pytest.importorskip('geopandas')
-
 import oggm
 from oggm import utils, workflow, tasks, global_tasks
 from oggm.utils import _downloads
@@ -30,6 +27,14 @@
                              DownloadVerificationFailedException)
 from oggm.core import flowline
 
+salem = pytest.importorskip('salem')
+gpd = pytest.importorskip('geopandas')
+
+# Python 3.12+ gives a deprecation warning if TarFile.extraction_filter is None.
+# https://docs.python.org/3.12/library/tarfile.html#tarfile-extraction-filter
+if hasattr(tarfile, "fully_trusted_filter"):
+    tarfile.TarFile.extraction_filter = staticmethod(tarfile.fully_trusted_filter)  # type: ignore
+
 
 pytestmark = pytest.mark.test_env("utils")
 
@@ -1675,7 +1680,7 @@ def test_start_from_prepro(self):
                           test_rgidf=rgidf, test_intersects_file=inter,
                           start_level=1, start_base_url=base_url,
                           mb_calibration_strategy='melt_temp',
-                          disable_mp=self.on_mac,
+                          disable_mp=True,  # Until CRU is fixed we just disable mp
                           logging_level='INFO', max_level=5, elev_bands=True,
                           override_params={'geodetic_mb_period': ref_period,
                                            'baseline_climate': 'CRU',
@@ -2536,7 +2541,6 @@ def test_file_extractor(self):
 
         # writing file to a tar.gz
         tmp_comp = os.path.join(cfg.PATHS['working_dir'], 'f.nc.tar.gz')
-        import tarfile
         with tarfile.open(tmp_comp, 'w:gz') as zip:
             zip.add(tmp_file, arcname='f.nc')
         of = utils.file_extractor(tmp_comp)

oggm/utils/_downloads.py

@@ -55,6 +55,11 @@
                              HttpDownloadError, HttpContentTooShortError,
                              InvalidDEMError, FTPSDownloadError)
 
+# Python 3.12+ gives a deprecation warning if TarFile.extraction_filter is None.
+# https://docs.python.org/3.12/library/tarfile.html#tarfile-extraction-filter
+if hasattr(tarfile, "fully_trusted_filter"):
+    tarfile.TarFile.extraction_filter = staticmethod(tarfile.fully_trusted_filter)  # type: ignore
+
 # Module logger
 logger = logging.getLogger('.'.join(__name__.split('.')[:-1]))
 

oggm/utils/_workflow.py

@@ -55,6 +55,10 @@
 except ImportError:
     pass
 
+# Python 3.12+ gives a deprecation warning if TarFile.extraction_filter is None.
+# https://docs.python.org/3.12/library/tarfile.html#tarfile-extraction-filter
+if hasattr(tarfile, "fully_trusted_filter"):
+    tarfile.TarFile.extraction_filter = staticmethod(tarfile.fully_trusted_filter)  # type: ignores
 
 # Locals
 from oggm import __version__