Update Project.toml #53
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JordiBolibar
reviewed
Jun 5, 2024
| @@ -141,9 +144,13 @@ function SIA2D(H::Matrix{R}, simulation::SIM, t::R; batch_id::Union{Nothing, I} | |||
| Fy = .-avg_x(D) .* dSdy_edges | |||
|
|
|||
| # Flux divergence | |||
| @tullio dH[i,j] := -(diff_x(Fx)[pad(i-1,1,1),pad(j-1,1,1)] / Δx + diff_y(Fy)[pad(i-1,1,1),pad(j-1,1,1)] / Δy) | |||
There was a problem hiding this comment.
@ChrisRackauckas I see you're working in the out-of-place version of the code. Since Enzyme supports in-place, why not directly switch to the SIA! function? That one doesn't have Tullio, and in the end it's the one we want to use, to avoid memory allocations.
There was a problem hiding this comment.
How do I switch to that? That would make it easier.
There was a problem hiding this comment.
You just have to change this line to Huginn.SIA2D!:
This reverts commit 2b005eb.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.