AUTHLIB-153: Adding workflow to publish SNAPSHOT jars #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -29,4 +29,18 @@ jobs: | |||
|
|
|||
| - name: Build with Maven | |||
| run: mvn package | |||
|
|
|||
| # Extract version from pom.xml | |||
| - name: Get Version from POM | |||
There was a problem hiding this comment.
The comments don't really add anything that isn't explained by the step name. I'd probably remove them.
.github/workflows/build.yaml
Outdated
|
|
||
| #Publish jar if `SNAPSHOT` is present in the version | ||
| - name: Publish SNAPSHOT JAR | ||
| if: contains(env.version, '-SNAPSHOT') |
There was a problem hiding this comment.
The other condition is that we only want to do this when code is merged to the main branch.
There was a problem hiding this comment.
It also looks like you need to add packages: write permission to the job.
heathharrelson
approved these changes
Dec 5, 2024
|
Made the suggested changes. It did behave the way it is expected to. It did not publish the JAR it generated. Once I merge it now, it should publish that JAR, I believe. Merging this PR now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Added workflow to publish SNAPSHOT jars
Issues
AUTHLIB-153
Discussion
.github/workflows/build.yamlworkflow to check if the version in project'spom.xmlhas the keywordSNAPSHOT