[18.0][MIG] web_chatter_postion: Migration to 18.0 #3056
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mailing module - Because the chatter in mass mailing form view lie under a notebook tab, if user choose sided chatter, it will disappear
[IMP] web_chatter_position: improve function compile web_chatter_position: propose myself as maintainer
|
It seems broken if I selected "side", could you have a look?
|
|
I'll take a look. Evidently the class selection is broader than expected. The changes on the UI had totally broken the "sided" option (it just behaved the same as responsive). I'll see if I can find the leak. |
ellbristow
force-pushed
the
18.0-mig-web_chatter_position
branch
from
2a96096 to
af58d7f
Compare
|
@DucTruongKomit Should be fixed now |
DucTruongKomit
approved these changes
Jan 17, 2025
|
@ellbristow ok now! Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Migration to 18.0
Includes minor code changes to account for changes in base form_renderer markup and JS handling.
App installs and functions.
No unit tests exist due to client-side nature of the module. Unchanged from previous version