-
-
Notifications
You must be signed in to change notification settings - Fork 75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[14.0] endpoint: add basic mixin view #56
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simahawk
added a commit
to camptocamp/edi
that referenced
this pull request
Jul 23, 2024
The new mixin view won't be affected by weird extensions. Requires OCA/web-api#56 Solves conflict w/ OCA/web-api-contrib#1
simahawk
force-pushed
the
14-fix-endpoint-view
branch
from
July 23, 2024 15:03
06f98c4
to
ec756b5
Compare
henrybackman
approved these changes
Jul 23, 2024
As the mixin can be inherited by many other models w/ their view an isolated basic view is required to avoid pollution and breakage of inherited views when extending the views of endpoint.endpoint. In particular, this solves a conflict that came w/ OCA/web-api-contrib#1
simahawk
force-pushed
the
14-fix-endpoint-view
branch
from
July 25, 2024 14:19
ec756b5
to
9679b5d
Compare
/ocabot merge minor |
On my way to merge this fine PR! |
Congratulations, your PR was merged at 82a678c. Thanks a lot for contributing to OCA. ❤️ |
simahawk
added a commit
to camptocamp/edi
that referenced
this pull request
Jul 26, 2024
The new mixin view won't be affected by weird extensions. Requires OCA/web-api#56 Solves conflict w/ OCA/web-api-contrib#1
simahawk
added a commit
to camptocamp/edi-framework
that referenced
this pull request
Jul 26, 2024
The new mixin view won't be affected by weird extensions. Requires OCA/web-api#56 Solves conflict w/ OCA/web-api-contrib#1
simahawk
added a commit
to camptocamp/web-api
that referenced
this pull request
Aug 8, 2024
Followup of OCA#56 The view must be registered for the mixin model otherwise it won't be taken into account. I've probably left this change in a stashed version :(
simahawk
added a commit
to camptocamp/web-api
that referenced
this pull request
Aug 8, 2024
Followup of OCA#56 The view must be registered for the mixin model otherwise it won't be taken into account. I've probably left this change in a stashed version :(
chaule97
pushed a commit
to camptocamp/edi-framework
that referenced
this pull request
Aug 29, 2024
The new mixin view won't be affected by weird extensions. Requires OCA/web-api#56 Solves conflict w/ OCA/web-api-contrib#1
chaule97
pushed a commit
to camptocamp/edi-framework
that referenced
this pull request
Sep 5, 2024
The new mixin view won't be affected by weird extensions. Requires OCA/web-api#56 Solves conflict w/ OCA/web-api-contrib#1
GuillemCForgeFlow
pushed a commit
to ForgeFlow/edi
that referenced
this pull request
Oct 29, 2024
The new mixin view won't be affected by weird extensions. Requires OCA/web-api#56 Solves conflict w/ OCA/web-api-contrib#1
GuillemCForgeFlow
pushed a commit
to ForgeFlow/edi
that referenced
this pull request
Oct 29, 2024
The new mixin view won't be affected by weird extensions. Requires OCA/web-api#56 Solves conflict w/ OCA/web-api-contrib#1
GuillemCForgeFlow
pushed a commit
to ForgeFlow/edi
that referenced
this pull request
Nov 7, 2024
The new mixin view won't be affected by weird extensions. Requires OCA/web-api#56 Solves conflict w/ OCA/web-api-contrib#1
GuillemCForgeFlow
pushed a commit
to ForgeFlow/edi
that referenced
this pull request
Nov 7, 2024
The new mixin view won't be affected by weird extensions. Requires OCA/web-api#56 Solves conflict w/ OCA/web-api-contrib#1
JordiMForgeFlow
pushed a commit
to ForgeFlow/edi
that referenced
this pull request
Nov 22, 2024
The new mixin view won't be affected by weird extensions. Requires OCA/web-api#56 Solves conflict w/ OCA/web-api-contrib#1
SilvioC2C
pushed a commit
to camptocamp/edi-framework
that referenced
this pull request
Dec 3, 2024
The new mixin view won't be affected by weird extensions. Requires OCA/web-api#56 Solves conflict w/ OCA/web-api-contrib#1
JordiMForgeFlow
pushed a commit
to ForgeFlow/edi-framework
that referenced
this pull request
Dec 17, 2024
The new mixin view won't be affected by weird extensions. Requires OCA/web-api#56 Solves conflict w/ OCA/web-api-contrib#1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As the mixin can be inherited by many other models w/ their view an isolated basic view is required to avoid pollution and breakage of inherited views when extending the views of endpoint.endpoint.
In particular, this solves a conflict that came w/ OCA/web-api-contrib#1
Companion PR for EDI: OCA/edi#1012