fs_storage: add possibility to define options values from env. #303
Conversation
adrienpeiffer
force-pushed
the
env-var-fs-attachment-ape
branch
3 times, most recently
from
8855421 to
fb43a86
Compare
|
Looks good (code review). This should simplify configuration by letting us configure everything in a record with embedded environment variables such as, say, |
|
This PR has the |
| _logger.warning( | ||
| f"Environment variable {env_variable_name} is not set for " | ||
| f"fs_storage {self.display_name}." |
There was a problem hiding this comment.
| _logger.warning( | |
| f"Environment variable {env_variable_name} is not set for " | |
| f"fs_storage {self.display_name}." | |
| _logger.warning( | |
| "Environment variable %s is not set for " | |
| "fs_storage %s", env_variable_name, self.display_name |
|
|
||
| eval_options_from_env = fields.Boolean( | ||
| string="Resolve env vars", | ||
| help="Resolve options values starting with $ from environment variables", |
There was a problem hiding this comment.
I would provide an example here
There was a problem hiding this comment.
Thank you @adrienpeiffer
Can you complete the documentation in https://github.com/OCA/storage/blob/16.0/fs_storage/readme/USAGE.rst to describe this new option for configuring a storage backend?
Can you also add a file 303.feature into the fs_storage/readme/newsfragment directory to describe this new feature. This file will be use at merge to fill the history section into the readme file and help users to know what changes have been made between versions.
adrienpeiffer
force-pushed
the
env-var-fs-attachment-ape
branch
2 times, most recently
from
5c3f9c4 to
f2fe690
Compare
adrienpeiffer
force-pushed
the
env-var-fs-attachment-ape
branch
from
f2fe690 to
8c31c7e
Compare
|
@lmignon Could be merged for Xmas ? |
|
/ocabot merge minor |
|
Hey, thanks for contributing! Proceeding to merge this for you. |
|
@adrienpeiffer can you handle the two comments from Simone? |
|
I have cancelled the merge. |
|
Congratulations, your PR was merged at 359ac46. Thanks a lot for contributing to OCA. ❤️ |
|
@sbidoul Seems not cancelled. I'll handle that in an other PR. |
No description provided.