Merge PR #302 into 16.0

Signed-off-by lmignon

fs_attachment/README.rst

@@ -7,7 +7,7 @@ Base Attachment Object Store
    !! This file is generated by oca-gen-addon-readme !!
    !! changes will be overwritten.                   !!
    !!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!
-   !! source digest: sha256:6ae379e8e8c8bea3d8c3452da7f64b766a5a1c816c388340a4b3d732730e683f
+   !! source digest: sha256:ec779601ef6dc2ae2d25d7a9339390881be25ced9802ffc9611abbfd7a9d05e5
    !!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!
 
 .. |badge1| image:: https://img.shields.io/badge/maturity-Beta-yellow.png

fs_attachment/models/fs_storage.py

@@ -412,7 +412,9 @@ def _get_url_for_attachment(
         # always remove the directory_path from the fs_filename
         # only if it's at the start of the filename
         fs_filename = attachment.fs_filename
-        if fs_filename.startswith(fs_storage.directory_path):
+        if fs_storage.directory_path and fs_filename.startswith(
+            fs_storage.directory_path
+        ):
             fs_filename = fs_filename.replace(fs_storage.directory_path, "")
         parts = [base_url, fs_filename]
         return self._normalize_url("/".join(parts))

fs_attachment/readme/newsfragments/302.bugfix

@@ -0,0 +1 @@
+Fix error when an url is computed for an attachment in a storage configure wihtout directory path.

fs_attachment/static/description/index.html

@@ -367,7 +367,7 @@ <h1 class="title">Base Attachment Object Store</h1>
 !! This file is generated by oca-gen-addon-readme !!
 !! changes will be overwritten.                   !!
 !!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!
-!! source digest: sha256:6ae379e8e8c8bea3d8c3452da7f64b766a5a1c816c388340a4b3d732730e683f
+!! source digest: sha256:ec779601ef6dc2ae2d25d7a9339390881be25ced9802ffc9611abbfd7a9d05e5
 !!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!! -->
 <p><a class="reference external image-reference" href="https://odoo-community.org/page/development-status"><img alt="Beta" src="https://img.shields.io/badge/maturity-Beta-yellow.png" /></a> <a class="reference external image-reference" href="http://www.gnu.org/licenses/agpl-3.0-standalone.html"><img alt="License: AGPL-3" src="https://img.shields.io/badge/licence-AGPL--3-blue.png" /></a> <a class="reference external image-reference" href="https://github.com/OCA/storage/tree/16.0/fs_attachment"><img alt="OCA/storage" src="https://img.shields.io/badge/github-OCA%2Fstorage-lightgray.png?logo=github" /></a> <a class="reference external image-reference" href="https://translation.odoo-community.org/projects/storage-16-0/storage-16-0-fs_attachment"><img alt="Translate me on Weblate" src="https://img.shields.io/badge/weblate-Translate%20me-F47D42.png" /></a> <a class="reference external image-reference" href="https://runboat.odoo-community.org/builds?repo=OCA/storage&amp;target_branch=16.0"><img alt="Try me on Runboat" src="https://img.shields.io/badge/runboat-Try%20me-875A7B.png" /></a></p>
 <p>In some cases, you need to store attachment in another system that the Odoo’s