[16.0][FIX] stock_picking_restrict_cancel_printed: allow moves merge #1834
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jbaudoux
changed the title
Support moves merge
jbaudoux
force-pushed
the
16-stock_picking_restrict_cancel_printed-fix_move_merge
branch
from
05e6dc8 to
a1ff3c2
Compare
mt-software-de
suggested changes
Jan 17, 2025
| This will trigger the creation of an extra move. | ||
| That extra gets merged and then canceled. | ||
| """ | ||
| self.picking.printed = True |
There was a problem hiding this comment.
Shouldn't be restrict_cancel_if_printed set to true.
Otherwise it will always call super._action_cancel?
Suggested change
| self.picking.printed = True | |
| self.picking_type.restrict_cancel_if_printed = True | |
| self.picking.printed = True |
There was a problem hiding this comment.
there is a default=True, so should be the case
mt-software-de
approved these changes
Jan 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support validation of picking with quantity in excess. Odoo creates an extra move that gets merged and then canceled. No need to allow this cancellation.
@santostelmo @rousseldenis @mt-software-de