[14.0][ADD] Add stock_split_picking_kit #1829
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TDu
force-pushed
the
14-add-stock_split_picking_kit
branch
from
f93ff2d to
988cd51
Compare
henrybackman
approved these changes
Jan 15, 2025
Comment on lines
3
to
5
| The new mode `Quantity of kits` allows to split a transfer by a specified number of kits. | ||
| A new field on the wizard also allows specify a sort order for the stock moves before | ||
| splitting the transfer. |
There was a problem hiding this comment.
Suggested change
| The new mode `Quantity of kits` allows to split a transfer by a specified number of kits. | |
| A new field on the wizard also allows specify a sort order for the stock moves before | |
| splitting the transfer. | |
| The new mode `Quantity of kits` allows splitting a transfer by a specified number of kits. | |
| A new field in the wizard also allows specifying a sort order for the stock moves before | |
| splitting the transfer. |
jbaudoux
requested changes
Jan 15, 2025
| "summary": "Split a picking by a number of kits.", | ||
| "version": "14.0.1.0.0", | ||
| "category": "Inventory", | ||
| "author": "Camptocamp, " "Odoo Community Association (OCA),", |
There was a problem hiding this comment.
Suggested change
| "author": "Camptocamp, " "Odoo Community Association (OCA),", | |
| "author": "Camptocamp, BCIM, Odoo Community Association (OCA),", |
| @@ -0,0 +1 @@ | |||
| * Thierry Ducrest <[email protected]> | |||
There was a problem hiding this comment.
Suggested change
| * Thierry Ducrest <[email protected]> | |
| * Thierry Ducrest <[email protected]> | |
| * Jacques-Etienne Baudoux (BCIM) <[email protected]> |
|
|
||
| def _apply_kit_quantity(self): | ||
| pickings = self.env["stock.picking"] | ||
| for picking in self.mapped("picking_ids"): |
There was a problem hiding this comment.
No need for mapped, isn't it ?
| used_slots = 0 | ||
| max_slots = self.kit_split_quantity | ||
| for bom, bom_move_list in groupby( | ||
| move_lines, key=lambda move: move.bom_line_id.bom_id |
There was a problem hiding this comment.
Add a note in DESCRIPTION that if we want to use this module on pulled move, we need this module in v14. It's standard since v15
And add a note multi level boms are not supported
| # Non kit moves, their quantity is the number of slots used | ||
| for move in moves: | ||
| quantity = move.product_qty | ||
| if available_slots >= move.product_qty: |
There was a problem hiding this comment.
Suggested change
| if available_slots >= move.product_qty: | |
| if available_slots >= quantity: |
| new_move_vals = [] | ||
| for move in moves: | ||
| new_move_vals += move._split( | ||
| move.bom_line_id.product_qty * kit_to_split |
There was a problem hiding this comment.
If you look at the bom_line_id.product_qty, why going through the complex _compute_kit_quantities ?
kit_quantity = move.product_qty / move.bom_line_id.product_qty
There was a problem hiding this comment.
Because it makes sure that the computed kits are complete.
| if moves_to_backorder: | ||
| new_picking = picking._create_split_backorder() | ||
| moves_to_backorder.write({"picking_id": new_picking.id}) | ||
| moves_to_backorder.mapped("move_line_ids").write( |
There was a problem hiding this comment.
No need for mapped, isn't it ?
| cls.partner = cls.env["res.partner"].create({"name": "Test partner"}) | ||
| cls.product_model = cls.env["product.product"] | ||
|
|
||
| # TODO: How should we handle kit with multiple level |
There was a problem hiding this comment.
Just write in DESCRIPTION you don't
Comment on lines
131
to
138
| filters = { | ||
| "incoming_moves": lambda m: m.location_id.usage == "supplier", | ||
| "outgoing_moves": lambda m: m.location_id.usage != "supplier", | ||
| } | ||
| kit_quantity = picking.move_lines._compute_kit_quantities( | ||
| bom.product_id, 100, bom, filters | ||
| ) | ||
| return abs(kit_quantity) |
There was a problem hiding this comment.
Same remark as above regarding filters & abs
| "outgoing_moves": lambda m: m.location_id.usage != "supplier", | ||
| } | ||
| kit_quantity = picking.move_lines._compute_kit_quantities( | ||
| bom.product_id, 100, bom, filters |
There was a problem hiding this comment.
Maybe like you did above
Suggested change
| bom.product_id, 100, bom, filters | |
| bom.product_id, max(picking.move_lines.mapped("product_qty")), bom, filters |
TDu
force-pushed
the
14-add-stock_split_picking_kit
branch
from
3489641 to
248a32e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.