[16.0][IMP] stock_move_line_change_lot: add hooks before/after moves reservation #1825
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Port of hooks that were added in `shopfloor` 14.0 after that this module was extracted from `shopfloor` during migration to 16.0: - OCA/wms/pull/712/commits/c296499726f0f95082bfe40bfb0c137dfd2fb690 - OCA/wms/pull/945/commits/28d4a0116e9c891cd1f37e794e3a7643798260ac
sebalix
force-pushed
the
16-stock_move_line_change_lot-add_hooks
branch
from
ba9cdd8 to
24fecbc
Compare
sebalix
commented
Jan 8, 2025
| @@ -161,6 +165,25 @@ def write(self, vals): | |||
| res &= super(StockMoveLine, self - already_processed).write(vals) | |||
|
|
|||
| if to_reassign_moves: | |||
| to_reassign_moves._action_assign() | |||
| self._handle_change_lot_reassign( | |||
There was a problem hiding this comment.
Put in a separate method to avoid flake8 issue:
stock_move_line_change_lot/models/stock_move_line.py:64:5: C901 'StockMoveLine.write' is too complex (17)
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the extraction of
shopfloor"change lot" action into thisstock_move_line_change_lotmodule in 16.0 (see OCA/wms@51d5f4ae25), we lost one feature (which was still not merged in 14.0 at that time, but now it is): addition of hooks before/after the reassignment of moves.This PR ports these hooks that were introduced in 14.0 in
shofploorhere: