Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[16.0][MIG]stock_orderpoint_origin_mrp_link: migration to 16.0 #22

Open
wants to merge 6 commits into
base: 16.0
Choose a base branch
from

Conversation

PicchiSeba
Copy link
Contributor

@PicchiSeba PicchiSeba commented Aug 13, 2024

This PR ports stock_orderpoint_origin_mrp_link to 16.0 (It also ports stock_orderpoint_origin because a single commit added both modules)

These modules come from https://github.com/OCA/stock-logistics-warehouse/tree/14.0/

@PicchiSeba PicchiSeba force-pushed the 16.0-mig-stock_orderpoint_origin_mrp_link branch from 9a51161 to fab0611 Compare August 13, 2024 10:16
@PicchiSeba PicchiSeba marked this pull request as ready for review August 13, 2024 10:16
@PicchiSeba PicchiSeba force-pushed the 16.0-mig-stock_orderpoint_origin_mrp_link branch from fab0611 to 19cbf3b Compare August 13, 2024 10:19
Copy link

@aleuffre aleuffre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code review, LGTM

@rousseldenis
Copy link
Contributor

/ocabot migration stock_orderpoint_origin_mrp_link

@OCA-git-bot OCA-git-bot added this to the 16.0 milestone Sep 17, 2024
@OCA-git-bot
Copy link
Contributor

There's no issue in this repo with the title 'Migration to version 16.0' and the milestone 16.0, so not possible to add the comment.

@giarve
Copy link

giarve commented Sep 17, 2024

Interesting... if compatible with
OCA/purchase-workflow#1983
and its equivalent for mrp, it would make Odoo with orderpoint MTS replenishment equivalent to MTO with more flexibility (without the need for default MTS + MTO route)

@PicchiSeba
Copy link
Contributor Author

Hi @giarve , I'm not familiar with the module you linked. What do you propose to increase compatibility?

@giarve
Copy link

giarve commented Oct 4, 2024

Hi @giarve , I'm not familiar with the module you linked. What do you propose to increase compatibility?

I have not tried them both at the same time yet. Theoretically they should both work because origin is split by , and that's what the module uses to find the source (origin) orders.

What I thought is interesting is that when using this module and filling the origin field, an equivalent module to "purchase_sale_link_by_origin" for mrp, could directly link manufacturing orders generated from the orderpoint to the sales order even when not using MTO route (and using the replenishment window).

@PicchiSeba
Copy link
Contributor Author

Hello @giarve , I finally had the time to take a look at OCA/purchase-workflow#1983. But it seems they do things differently.

I would keep them separated, at least for this migration.
We might want to change the behaviour in the future once this module is in a stable state.

@PicchiSeba PicchiSeba force-pushed the 16.0-mig-stock_orderpoint_origin_mrp_link branch from 19cbf3b to 46f0c2f Compare December 10, 2024 11:44
@PicchiSeba PicchiSeba marked this pull request as draft December 10, 2024 11:44
@PicchiSeba PicchiSeba marked this pull request as ready for review December 11, 2024 13:03
@PicchiSeba PicchiSeba force-pushed the 16.0-mig-stock_orderpoint_origin_mrp_link branch from 46f0c2f to 2988b20 Compare December 13, 2024 11:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants