-
-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[16.0][MIG]stock_orderpoint_origin_mrp_link: migration to 16.0
#22
base: 16.0
Are you sure you want to change the base?
[16.0][MIG]stock_orderpoint_origin_mrp_link: migration to 16.0
#22
Conversation
9a51161
to
fab0611
Compare
fab0611
to
19cbf3b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code review, LGTM
/ocabot migration stock_orderpoint_origin_mrp_link |
There's no issue in this repo with the title 'Migration to version 16.0' and the milestone 16.0, so not possible to add the comment. |
Interesting... if compatible with |
Hi @giarve , I'm not familiar with the module you linked. What do you propose to increase compatibility? |
I have not tried them both at the same time yet. Theoretically they should both work because origin is split by , and that's what the module uses to find the source (origin) orders. What I thought is interesting is that when using this module and filling the origin field, an equivalent module to "purchase_sale_link_by_origin" for mrp, could directly link manufacturing orders generated from the orderpoint to the sales order even when not using MTO route (and using the replenishment window). |
Hello @giarve , I finally had the time to take a look at OCA/purchase-workflow#1983. But it seems they do things differently. I would keep them separated, at least for this migration. |
19cbf3b
to
46f0c2f
Compare
46f0c2f
to
2988b20
Compare
This PR ports
stock_orderpoint_origin_mrp_link
to16.0
(It also portsstock_orderpoint_origin
because a single commit added both modules)These modules come from https://github.com/OCA/stock-logistics-warehouse/tree/14.0/