-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[18.0][MIG] base_name_search_improved: Migration to 18.0 #3133
base: 18.0
Are you sure you want to change the base?
Conversation
Currently translated at 100.0% (2 of 2 strings) Translation: server-tools-9.0/server-tools-9.0-base_name_search_improved Translate-URL: https://translation.odoo-community.org/projects/server-tools-9-0/server-tools-9-0-base_name_search_improved/ca/
- Descriptor: change __openerp__.py file to __manifest__.py also update module version from 9.0.1.0.0 to 11.0.1.0.0 - Update README using guideline - Views: replace view tag openerp to odoo and rename files to match guideline - Models - update imports from openerp to odoo - remove enconding line # -*- coding: utf-8 -*- - update to make it compatible - remove use of SUPERUSER_ID use sudo instead. - rename class name to make it match with guideline. - update methods to match api used in version 11.0 - fix pylint errors - replace use of non exist self._model with self._name - use `Model `is not None instead of if `Model` this becuase the last one is a empty recordset and this one was evaluate to False and never was patching the method. - apply changes resquested/suggested in the PR by the reviewers.
Updated by Update PO files to match POT (msgmerge) hook in Weblate.
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: server-tools-14.0/server-tools-14.0-base_name_search_improved Translate-URL: https://translation.odoo-community.org/projects/server-tools-14-0/server-tools-14-0-base_name_search_improved/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: server-tools-14.0/server-tools-14.0-base_name_search_improved Translate-URL: https://translation.odoo-community.org/projects/server-tools-14-0/server-tools-14-0-base_name_search_improved/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: server-tools-14.0/server-tools-14.0-base_name_search_improved Translate-URL: https://translation.odoo-community.org/projects/server-tools-14-0/server-tools-14-0-base_name_search_improved/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: server-tools-14.0/server-tools-14.0-base_name_search_improved Translate-URL: https://translation.odoo-community.org/projects/server-tools-14-0/server-tools-14-0-base_name_search_improved/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: server-tools-16.0/server-tools-16.0-base_name_search_improved Translate-URL: https://translation.odoo-community.org/projects/server-tools-16-0/server-tools-16-0-base_name_search_improved/
Currently translated at 100.0% (25 of 25 strings) Translation: server-tools-16.0/server-tools-16.0-base_name_search_improved Translate-URL: https://translation.odoo-community.org/projects/server-tools-16-0/server-tools-16-0-base_name_search_improved/es/
Currently translated at 36.0% (9 of 25 strings) Translation: server-tools-16.0/server-tools-16.0-base_name_search_improved Translate-URL: https://translation.odoo-community.org/projects/server-tools-16-0/server-tools-16-0-base_name_search_improved/it/
Currently translated at 36.0% (9 of 25 strings) Translation: server-tools-16.0/server-tools-16.0-base_name_search_improved Translate-URL: https://translation.odoo-community.org/projects/server-tools-16-0/server-tools-16-0-base_name_search_improved/it/
Currently translated at 100.0% (25 of 25 strings) Translation: server-tools-16.0/server-tools-16.0-base_name_search_improved Translate-URL: https://translation.odoo-community.org/projects/server-tools-16-0/server-tools-16-0-base_name_search_improved/it/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: server-tools-16.0/server-tools-16.0-base_name_search_improved Translate-URL: https://translation.odoo-community.org/projects/server-tools-16-0/server-tools-16-0-base_name_search_improved/
When applying monkey patches, we want to skip abstract models because patching those may mess up the inheritance. An example of this is ir.model which is assigned the studio mixin using inherit = ['studio.mixin', 'ir.model']. If the mixin itself is patched, and the method is overridden once again (in, say, enterprise 15's documents_spreadsheet), the super() method called in that override is the patched version of studio.mixin rather than the override of ir.model in the base module, which is now skipped entirely.
8bce573
to
5fda9a2
Compare
5fda9a2
to
ecc6179
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Functional review ok!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This PR has the |
Migrated through this pr #2831