Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[17.0][FIX] server_environment: hide password for smtp connection #217

Closed
wants to merge 1 commit into from
Closed

[17.0][FIX] server_environment: hide password for smtp connection #217

wants to merge 1 commit into from

Conversation

kafai-lam
Copy link

Current issue: smtp_pass value which defined in [outgoing_mail] from mail_environment module will got exposed

@leemannd
Copy link

Hello, could you check this PR? #210
I'm more in favor of this implementation that could be backported in 17.0

StefanRijnhart
StefanRijnhart requested changes Feb 5, 2025
View reviewed changes
Copy link
Member

@StefanRijnhart StefanRijnhart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed with @leemannd, please backport #210 as it's more comprehensive.

@kafai-lam
Copy link
Author

Good, I may close this PR then

@kafai-lam kafai-lam closed this Feb 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@StefanRijnhart StefanRijnhart StefanRijnhart requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kafai-lam @leemannd @StefanRijnhart