[IMP][16.0] auth_saml: download the provider metadata #739
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @vincent-hatakeyama, |
dutrieuc
changed the title
dutrieuc
force-pushed
the
16.0-auth_saml_metadata
branch
2 times, most recently
from
c0156e7 to
aa1f1e1
Compare
|
Hello @vincent-hatakeyama, |
vincent-hatakeyama
suggested changes
Jan 22, 2025
Comment on lines
430
to
433
| provider_ids = tuple(providers_to_update.keys()) | ||
| self.env.cr.execute( | ||
| "SELECT id FROM auth_saml_provider WHERE id in %s FOR UPDATE", | ||
| (tuple(providers.ids),), | ||
| (tuple(provider_ids),), |
There was a problem hiding this comment.
provider_idsis already a tuple, why use tuple again?
|
The last 3 commits need to be squashed and their title fixed. The second commit title also does not match OCA standards. |
On Office365, what you get when configuring an application for SAML authentication is the URL of the federation metadata document. This URL is stable, but the content of the document is not. I suspect some of the encryption keys can be updated / renewed over time. The result is that the configured provider in Odoo suddenly stops working, because the messages sent by the Office365 provider can no longer be validated by Odoo (because the federation document is out of date). Downloading the new version and updating the auth.saml.provider record fixes the issue. This PR adds a new field to store the URL of the metadata document. When this field is set on a provider, you get a button next to it in the form view to download the document from the URL. The button will not update the document if it has not changed. Additionally, when a SignatureError happens, we check if downloading the document again fixes the issue.
Fix logic of SELECT FOR UDPDATE to only lock records whose metadata will be updated
dutrieuc
force-pushed
the
16.0-auth_saml_metadata
branch
from
589c76d to
11343aa
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reopening of #647
Migration to 16 of #602 feature