-
-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[IMP] sale_order_invoicing_finished_task #556
[IMP] sale_order_invoicing_finished_task #556
Conversation
@rafaelbn @sergio-teruel this PR adds the bit I'm missing in the new code from #485 : for fixed price sales lines, I really need the delivered qty to be == ordered qty when the task is set as invoiceable. (I'm using these values to convert these to amounts and cannot afford to have 2 different and incompatible units in theses columns, such as Units and Hours). |
('amount', '<=', 0.0), | ||
('project_id', '!=', False), | ||
] | ||
print domain |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove the print
e5e2043
to
7ff584d
Compare
When the product has an invoicing policy Ordered Quantity, setting the task as Invoiceable will set the delivered qty on the sale order line to the ordered quantity.
7ff584d
to
ba49046
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I suppose that you want to track the line via timesheets but still have a fixed price. This is a bit outside the scope of this module, but well, we can include it.
Tested in runbot 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please merge after travis is green! Thanks!
I added a commit to fix flake8 errors. |
When the product has an invoicing policy Ordered Quantity, setting the task as Invoiceable will set the delivered qty on the sale order line to the ordered quantity.
When the product has an invoicing policy Ordered Quantity, setting the task as Invoiceable will set the delivered qty on the sale order line to the ordered quantity.
When the product has an invoicing policy Ordered Quantity, setting the task as Invoiceable will set the delivered qty on the sale order line to the ordered quantity.
When the product has an invoicing policy Ordered Quantity, setting the task as Invoiceable will set the delivered qty on the sale order line to the ordered quantity.
When the product has an invoicing policy Ordered Quantity, setting the task as Invoiceable will set the delivered qty on the sale order line to the ordered quantity.
When the product has an invoicing policy Ordered Quantity, setting the task as Invoiceable will set the delivered qty on the sale order line to the ordered quantity.
When the product has an invoicing policy Ordered Quantity, setting the task as Invoiceable will set the delivered qty on the sale order line to the ordered quantity.
When the product has an invoicing policy Ordered Quantity, setting the task as Invoiceable will set the delivered qty on the sale order line to the ordered quantity.
When the product has an invoicing policy Ordered Quantity, setting the task as Invoiceable will set the delivered qty on the sale order line to the ordered quantity.
When the product has an invoicing policy Ordered Quantity, setting the task as Invoiceable will set the delivered qty on the sale order line to the ordered quantity.
When the product has an invoicing policy Ordered Quantity, setting the task as Invoiceable will set the delivered qty on the sale order line to the ordered quantity.
When the product has an invoicing policy Ordered Quantity, setting the task as Invoiceable will set the delivered qty on the sale order line to the ordered quantity.
When the product has an invoicing policy Ordered Quantity, setting the task as Invoiceable will set the delivered qty on the sale order line to the ordered quantity.
When the product has an invoicing policy Ordered Quantity, setting the task as Invoiceable will set the delivered qty on the sale order line to the ordered quantity.
When the product has an invoicing policy Ordered Quantity, setting the task as Invoiceable will set the delivered qty on the sale order line to the ordered quantity.
When the product has an invoicing policy Ordered Quantity, setting the task as Invoiceable will set the delivered qty on the sale order line to the ordered quantity.
When the product has an invoicing policy Ordered Quantity, setting the task as Invoiceable will set the delivered qty on the sale order line to the ordered quantity.
When the product has an invoicing policy Ordered Quantity, setting the task as Invoiceable will set the delivered qty on the sale order line to the ordered quantity.
When the product has an invoicing policy Ordered Quantity, setting the task as Invoiceable will set the delivered qty on the sale order line to the ordered quantity.
When the product has an invoicing policy Ordered Quantity, setting the task as Invoiceable will set the delivered qty on the sale order line to the ordered quantity.
When the product has an invoicing policy Ordered Quantity, setting the task as Invoiceable will set the delivered qty on the sale order line to the ordered quantity.
When the product has an invoicing policy Ordered Quantity, setting the task as Invoiceable will set the delivered qty on the sale order line to the ordered quantity.
When the product has an invoicing policy Ordered Quantity, setting the task as Invoiceable will set the delivered qty on the sale order line to the ordered quantity.
When the product has an invoicing policy Ordered Quantity, setting the task as Invoiceable will set the delivered qty on the sale order line to the ordered quantity.
When the product has an invoicing policy Ordered Quantity, setting the task as Invoiceable will set the delivered qty on the sale order line to the ordered quantity.
When the product has an invoicing policy Ordered Quantity, setting the task as Invoiceable will set the delivered qty on the sale order line to the ordered quantity.
When the product has an invoicing policy Ordered Quantity, setting the task as Invoiceable will set the delivered qty on the sale order line to the ordered quantity.
When the product has an invoicing policy Ordered Quantity, setting the task as Invoiceable will set the delivered qty on the sale order line to the ordered quantity.
When the product has an invoicing policy Ordered Quantity, setting the task as Invoiceable will set the delivered qty on the sale order line to the ordered quantity.
When the product has an invoicing policy Ordered Quantity, setting the task as Invoiceable will set the delivered qty on the sale order line to the ordered quantity.
When the product has an invoicing policy Ordered Quantity, setting the task as Invoiceable will set the delivered qty on the sale order line to the ordered quantity.
When the product has an invoicing policy Ordered Quantity, setting the task as Invoiceable will set the delivered qty on the sale order line to the ordered quantity.
When the product has an invoicing policy Ordered Quantity, setting the task as Invoiceable will set the delivered qty on the sale order line to the ordered quantity.
When the product has an invoicing policy Ordered Quantity, setting the task as Invoiceable will set the delivered qty on the sale order line to the ordered quantity.
When the product has an invoicing policy Ordered Quantity, setting the task as Invoiceable will set the delivered qty on the sale order line to the ordered quantity.
When the product has an invoicing policy Ordered Quantity, setting the task as Invoiceable will set the delivered qty on the sale order line to the ordered quantity.
When the product has an invoicing policy Ordered Quantity, setting the task
as Invoiceable will set the delivered qty on the sale order line to the ordered quantity.