Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[IMP] sale_order_invoicing_finished_task #556

Merged

Conversation

gurneyalex
Copy link
Member

When the product has an invoicing policy Ordered Quantity, setting the task
as Invoiceable will set the delivered qty on the sale order line to the ordered quantity.

@gurneyalex
Copy link
Member Author

@rafaelbn @sergio-teruel this PR adds the bit I'm missing in the new code from #485 : for fixed price sales lines, I really need the delivered qty to be == ordered qty when the task is set as invoiceable. (I'm using these values to convert these to amounts and cannot afford to have 2 different and incompatible units in theses columns, such as Units and Hours).

('amount', '<=', 0.0),
('project_id', '!=', False),
]
print domain
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove the print

@gurneyalex gurneyalex force-pushed the 10.0-improve_sale_order_invoicing_finished_task branch 2 times, most recently from e5e2043 to 7ff584d Compare October 31, 2017 14:26
When the product has an invoicing policy Ordered Quantity, setting the task
as Invoiceable will set the delivered qty on the sale order line to the ordered quantity.
@pedrobaeza pedrobaeza force-pushed the 10.0-improve_sale_order_invoicing_finished_task branch from 7ff584d to ba49046 Compare November 2, 2017 18:53
Copy link
Member

@pedrobaeza pedrobaeza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suppose that you want to track the line via timesheets but still have a fixed price. This is a bit outside the scope of this module, but well, we can include it.

@rafaelbn rafaelbn added this to the 10.0 milestone Nov 2, 2017
@rafaelbn
Copy link
Member

rafaelbn commented Nov 2, 2017

Tested in runbot 👍
But travis is red @gurneyalex

Copy link
Member

@rafaelbn rafaelbn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please merge after travis is green! Thanks!

@jcoux
Copy link
Contributor

jcoux commented Feb 27, 2018

I added a commit to fix flake8 errors.

@pedrobaeza pedrobaeza merged commit 30ad095 into OCA:10.0 Feb 27, 2018
carlosdauden pushed a commit to Tecnativa/sale-workflow that referenced this pull request Apr 4, 2018
When the product has an invoicing policy Ordered Quantity, setting the task
as Invoiceable will set the delivered qty on the sale order line to the ordered quantity.
murtuzasaleh pushed a commit to murtuzasaleh/sale-workflow that referenced this pull request Jul 6, 2018
When the product has an invoicing policy Ordered Quantity, setting the task
as Invoiceable will set the delivered qty on the sale order line to the ordered quantity.
LoisRForgeFlow pushed a commit to LoisRForgeFlow/sale-workflow that referenced this pull request Jul 17, 2018
When the product has an invoicing policy Ordered Quantity, setting the task
as Invoiceable will set the delivered qty on the sale order line to the ordered quantity.
sylvainvh pushed a commit to camptocamp/sale-workflow that referenced this pull request Feb 5, 2019
When the product has an invoicing policy Ordered Quantity, setting the task
as Invoiceable will set the delivered qty on the sale order line to the ordered quantity.
Tardo pushed a commit to Tecnativa/sale-workflow that referenced this pull request Jun 19, 2019
When the product has an invoicing policy Ordered Quantity, setting the task
as Invoiceable will set the delivered qty on the sale order line to the ordered quantity.
OCA-git-bot pushed a commit that referenced this pull request Jul 20, 2019
When the product has an invoicing policy Ordered Quantity, setting the task
as Invoiceable will set the delivered qty on the sale order line to the ordered quantity.
HirenDangar pushed a commit to HirenDangar/sale-workflow that referenced this pull request Mar 6, 2020
When the product has an invoicing policy Ordered Quantity, setting the task
as Invoiceable will set the delivered qty on the sale order line to the ordered quantity.
blopa98-S73 pushed a commit to Studio73/sale-workflow that referenced this pull request Sep 8, 2020
When the product has an invoicing policy Ordered Quantity, setting the task
as Invoiceable will set the delivered qty on the sale order line to the ordered quantity.
Nikul-Chaudhary pushed a commit to Nikul-Chaudhary/sale-workflow that referenced this pull request Oct 3, 2020
When the product has an invoicing policy Ordered Quantity, setting the task
as Invoiceable will set the delivered qty on the sale order line to the ordered quantity.
joao-p-marques pushed a commit to Tecnativa/sale-workflow that referenced this pull request Feb 10, 2021
When the product has an invoicing policy Ordered Quantity, setting the task
as Invoiceable will set the delivered qty on the sale order line to the ordered quantity.
ThomasBinsfeld pushed a commit to acsone/sale-workflow that referenced this pull request Mar 23, 2021
When the product has an invoicing policy Ordered Quantity, setting the task
as Invoiceable will set the delivered qty on the sale order line to the ordered quantity.
ThomasBinsfeld pushed a commit to acsone/sale-workflow that referenced this pull request Mar 23, 2021
When the product has an invoicing policy Ordered Quantity, setting the task
as Invoiceable will set the delivered qty on the sale order line to the ordered quantity.
ThomasBinsfeld pushed a commit to acsone/sale-workflow that referenced this pull request Mar 23, 2021
When the product has an invoicing policy Ordered Quantity, setting the task
as Invoiceable will set the delivered qty on the sale order line to the ordered quantity.
ivantodorovich pushed a commit to odoo-it/sale-workflow that referenced this pull request Apr 21, 2021
When the product has an invoicing policy Ordered Quantity, setting the task
as Invoiceable will set the delivered qty on the sale order line to the ordered quantity.
ernestotejeda pushed a commit to Tecnativa/sale-workflow that referenced this pull request Feb 17, 2022
When the product has an invoicing policy Ordered Quantity, setting the task
as Invoiceable will set the delivered qty on the sale order line to the ordered quantity.
sergio-teruel pushed a commit to Tecnativa/sale-workflow that referenced this pull request Jun 18, 2022
When the product has an invoicing policy Ordered Quantity, setting the task
as Invoiceable will set the delivered qty on the sale order line to the ordered quantity.
dreispt pushed a commit to ursais/sale-workflow that referenced this pull request Jun 21, 2022
When the product has an invoicing policy Ordered Quantity, setting the task
as Invoiceable will set the delivered qty on the sale order line to the ordered quantity.
cesar-tecnativa pushed a commit to Tecnativa/sale-workflow that referenced this pull request Jun 30, 2022
When the product has an invoicing policy Ordered Quantity, setting the task
as Invoiceable will set the delivered qty on the sale order line to the ordered quantity.
cesar-tecnativa pushed a commit to Tecnativa/sale-workflow that referenced this pull request Jul 26, 2022
When the product has an invoicing policy Ordered Quantity, setting the task
as Invoiceable will set the delivered qty on the sale order line to the ordered quantity.
CarlosRoca13 pushed a commit to Tecnativa/sale-workflow that referenced this pull request Aug 2, 2022
When the product has an invoicing policy Ordered Quantity, setting the task
as Invoiceable will set the delivered qty on the sale order line to the ordered quantity.
santostelmo pushed a commit to santostelmo/sale-workflow that referenced this pull request Aug 23, 2022
When the product has an invoicing policy Ordered Quantity, setting the task
as Invoiceable will set the delivered qty on the sale order line to the ordered quantity.
imlopes pushed a commit to camptocamp/sale-workflow that referenced this pull request Sep 15, 2022
When the product has an invoicing policy Ordered Quantity, setting the task
as Invoiceable will set the delivered qty on the sale order line to the ordered quantity.
pilarvargas-tecnativa pushed a commit to Tecnativa/sale-workflow that referenced this pull request Feb 7, 2023
When the product has an invoicing policy Ordered Quantity, setting the task
as Invoiceable will set the delivered qty on the sale order line to the ordered quantity.
dsolanki-initos pushed a commit to initOS/sale-workflow that referenced this pull request Apr 17, 2023
When the product has an invoicing policy Ordered Quantity, setting the task
as Invoiceable will set the delivered qty on the sale order line to the ordered quantity.
Yadier-Tecnativa pushed a commit to Tecnativa/sale-workflow that referenced this pull request May 12, 2023
When the product has an invoicing policy Ordered Quantity, setting the task
as Invoiceable will set the delivered qty on the sale order line to the ordered quantity.
Yadier-Tecnativa pushed a commit to Tecnativa/sale-workflow that referenced this pull request May 17, 2023
When the product has an invoicing policy Ordered Quantity, setting the task
as Invoiceable will set the delivered qty on the sale order line to the ordered quantity.
Yadier-Tecnativa pushed a commit to Tecnativa/sale-workflow that referenced this pull request Jun 7, 2023
When the product has an invoicing policy Ordered Quantity, setting the task
as Invoiceable will set the delivered qty on the sale order line to the ordered quantity.
Yadier-Tecnativa pushed a commit to Tecnativa/sale-workflow that referenced this pull request Jun 7, 2023
When the product has an invoicing policy Ordered Quantity, setting the task
as Invoiceable will set the delivered qty on the sale order line to the ordered quantity.
Yadier-Tecnativa pushed a commit to Tecnativa/sale-workflow that referenced this pull request Jul 12, 2023
When the product has an invoicing policy Ordered Quantity, setting the task
as Invoiceable will set the delivered qty on the sale order line to the ordered quantity.
nguyenminhchien pushed a commit to nguyenminhchien/sale-workflow that referenced this pull request Oct 6, 2023
When the product has an invoicing policy Ordered Quantity, setting the task
as Invoiceable will set the delivered qty on the sale order line to the ordered quantity.
santostelmo pushed a commit to camptocamp/sale-workflow that referenced this pull request Oct 27, 2023
When the product has an invoicing policy Ordered Quantity, setting the task
as Invoiceable will set the delivered qty on the sale order line to the ordered quantity.
Ricardoalso pushed a commit to camptocamp/sale-workflow that referenced this pull request Nov 27, 2023
When the product has an invoicing policy Ordered Quantity, setting the task
as Invoiceable will set the delivered qty on the sale order line to the ordered quantity.
Ricardoalso pushed a commit to camptocamp/sale-workflow that referenced this pull request Nov 27, 2023
When the product has an invoicing policy Ordered Quantity, setting the task
as Invoiceable will set the delivered qty on the sale order line to the ordered quantity.
Ricardoalso pushed a commit to camptocamp/sale-workflow that referenced this pull request Nov 27, 2023
When the product has an invoicing policy Ordered Quantity, setting the task
as Invoiceable will set the delivered qty on the sale order line to the ordered quantity.
juanjosesegui-tecnativa pushed a commit to Tecnativa/sale-workflow that referenced this pull request Jul 22, 2024
When the product has an invoicing policy Ordered Quantity, setting the task
as Invoiceable will set the delivered qty on the sale order line to the ordered quantity.
omalbastin pushed a commit to omalbastin/sale-workflow that referenced this pull request Nov 25, 2024
When the product has an invoicing policy Ordered Quantity, setting the task
as Invoiceable will set the delivered qty on the sale order line to the ordered quantity.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants