Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[16.0] [FIX] sale_order_line_price_history: Add discount field only if discount group is enabled #3552

Open
wants to merge 1 commit into
base: 16.0
Choose a base branch
from

Conversation

Shide
Copy link
Contributor

@Shide Shide commented Jan 29, 2025

If you try to add historic prices with discounts group deactivated, an error raises because discount field is not present on the view (kanban and tree)
This adds a check to see if discount is present on the record fields and add the key-value of discount if exists.

Added discount with the group to the kanban view (when defining fields)

Also added a known issue:
If you add the historic price from the kanban view, the sale order save button doesn't work. You need to go into the line and click save.

MT-8826 @moduon @CarlosRoca13 @yajo please review if you want :)

@Shide Shide force-pushed the 16.0-fix_discount_field-sale_order_line_price_history branch from fe65e0e to f91f8fb Compare January 29, 2025 10:23
@Shide Shide changed the title [FIX] [16.0] sale_order_line_price_history: Add discount field only if discount group is enabled [16.0] [FIX] sale_order_line_price_history: Add discount field only if discount group is enabled Jan 29, 2025
@rafaelbn rafaelbn added this to the 16.0 milestone Jan 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants