Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[17.0][IMP]sale_quotation_number: Boolean to determine whether quotation sequence has been used #3534

Merged

Conversation

Tisho99
Copy link

@Tisho99 Tisho99 commented Jan 13, 2025

FW Port of #2719

The current fix doesn't work because it stops working if you use formulas in the prefixes of the succesors.

T-7243

@Tisho99 Tisho99 changed the title [IMP]sale_quotation_number: Boolean to determine whether quotation sequence has been used [17.0][IMP]sale_quotation_number: Boolean to determine whether quotation sequence has been used Jan 13, 2025
@Tisho99 Tisho99 force-pushed the 17.0-imp-sale_quotation_number branch from 1130c42 to 57f5f82 Compare January 13, 2025 14:19
@Tisho99
Copy link
Author

Tisho99 commented Jan 14, 2025

FW port not neccesary because it has already been fixed.

if sequence and self.name[: len(sequence.prefix)] != sequence.prefix:

@Tisho99 Tisho99 closed this Jan 14, 2025
@Tisho99 Tisho99 reopened this Jan 14, 2025
@Tisho99 Tisho99 force-pushed the 17.0-imp-sale_quotation_number branch 3 times, most recently from 4d7c2a4 to 9f76d8b Compare January 14, 2025 16:46
@Tisho99 Tisho99 marked this pull request as ready for review January 14, 2025 16:56
@Tisho99 Tisho99 force-pushed the 17.0-imp-sale_quotation_number branch from 9f76d8b to 94e7bba Compare January 14, 2025 16:59
@Tisho99
Copy link
Author

Tisho99 commented Jan 14, 2025

@Tisho99 Tisho99 force-pushed the 17.0-imp-sale_quotation_number branch from 94e7bba to af16f0c Compare January 15, 2025 08:35
Copy link
Contributor

@ValentinVinagre ValentinVinagre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍🏻

Copy link
Contributor

@manuelregidor manuelregidor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Technical review LGTM

Copy link
Contributor

@HaraldPanten HaraldPanten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@HaraldPanten
Copy link
Contributor

/ocabot merge patch

@OCA-git-bot
Copy link
Contributor

This PR looks fantastic, let's merge it!
Prepared branch 17.0-ocabot-merge-pr-3534-by-HaraldPanten-bump-patch, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 9f6aa0f into OCA:17.0 Jan 16, 2025
7 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at ad03b66. Thanks a lot for contributing to OCA. ❤️

@HaraldPanten HaraldPanten deleted the 17.0-imp-sale_quotation_number branch January 16, 2025 10:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants